Page MenuHomeSoftware Heritage

moma: swh-web: remove rate limiting for 192.168.0.0/16
ClosedPublic

Authored by seirl on Mar 26 2018, 3:00 PM.

Details

Reviewers
olasd

Diff Detail

Repository
rSPSITE puppet-swh-site
Branch
production
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1190
Build 1534: arc lint + arc unit

Event Timeline

What's the actual usecase for this? I'm a little bit wary of letting the local hosts hammer the frontend web service without justification :)

My usecase was to cook 500 vault bundles at once. Vault requests are painless for the web frontend, the rate limit is only for the backend.

As i said on IRC, I'm totally for having per ranges limits, so that we can keep a limit without being too large. But this requires some code change to allow a different limit depending on the range, so I'd rather have an exemption in the meantime.

This revision is now accepted and ready to land.Apr 9 2018, 3:00 PM