Differential D2975

webapp: Add keycloak configuration for production and staging
ClosedPublic
Actions

Authored by anlambert on Apr 7 2020, 6:41 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rSPSITE49ed9869b1b6: webapp: Add keycloak configuration for production and staging

Summary

Until the OIDC login feature got properly tested in staging environment,
do not set keycloak server URL for production environment in order to
hide the login link in deployed web application.

Related to T2048
Related to T1927

Diff Detail

Repository

rSPSITE puppet-swh-site

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 7 2020, 6:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2020, 6:41 PM

Harbormaster completed remote builds in B11656: Diff 10569.Apr 7 2020, 6:41 PM

ardumont added a subscriber: ardumont.Apr 8 2020, 10:04 AM

ardumont added inline comments.

data/defaults.yaml
1692	isn't it better to explicit an empty string here? # server_url: "https://%{hiera('keycloak::vhost::name')}/auth/" server_url: ""

anlambert added inline comments.Apr 8 2020, 12:24 PM

data/defaults.yaml
1692	Indeed. I will update the diff.

Update: Address @ardumont comment.

Harbormaster completed remote builds in B11673: Diff 10586.Apr 8 2020, 12:26 PM

lgtm

This revision is now accepted and ready to land.Apr 8 2020, 12:31 PM

Closed by commit rSPSITE49ed9869b1b6: webapp: Add keycloak configuration for production and staging (authored by anlambert). · Explain WhyApr 8 2020, 12:34 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rSPSITE49ed9869b1b6: webapp: Add keycloak configuration for production and staging.

ardumont mentioned this in D2982: webapp: fix keycloak setup.Apr 8 2020, 4:54 PM

ardumont mentioned this in rSPSITE4aa0c7d15861: webapp: fix keycloak setup.Apr 8 2020, 4:56 PM

Revision Contents
Changeset List

Path

Size

data/

defaults.yaml

7 lines

hostname/

webapp.internal.staging.swh.network.yaml

3 lines

Diff 10587

View Options

data/defaults.yaml