Differential D285

cookers: add a max bundle size
ClosedPublic
Actions

Authored by seirl on Jan 11 2018, 6:09 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T894: Vault: add limits for the max size of the objects that can be cooked

Commits

rDVAU3738ae32abe0: cookers: configurable max bundle size
rDVAUe8419e9b9f16: cookers: add a max bundle size

Diff Detail

Repository

rDVAU Software Heritage Vault

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seirl created this revision.Jan 11 2018, 6:09 PM

Harbormaster completed remote builds in B1152: Diff 958.Jan 11 2018, 6:09 PM

seirl added a reviewer: Reviewers.Jan 11 2018, 6:09 PM

One relevant change requested (make max size configurable) + one nit.
LGTM otherwise.

swh/vault/cookers/base.py
33	this should be a configuration option, rather than hard-coded
104	maybe instead of a string that just repeat the exception name the message can say what the limit was and that this bundle bypassed it?
112	loved the xkcd/sudo pun here :)

This revision now requires changes to proceed.Jan 12 2018, 9:38 AM

cookers: configurable max bundle size

Harbormaster completed remote builds in B1153: Diff 959.Jan 12 2018, 12:59 PM

zack requested changes to this revision.Jan 12 2018, 1:46 PM

zack added inline comments.

swh/vault/cookers/base.py
106	it looks like your units for the configuration part is bytes, not MiB, so this should be updated (sorry :-))
178	ditto

This revision now requires changes to proceed.Jan 12 2018, 1:46 PM

fix error message: MiB -> bytes

Harbormaster completed remote builds in B1154: Diff 960.Jan 12 2018, 2:37 PM

Closed by commit rDVAUe8419e9b9f16: cookers: add a max bundle size (authored by seirl). · Explain WhyJan 12 2018, 2:37 PM

This revision was automatically updated to reflect the committed changes.

seirl added a task: T894: Vault: add limits for the max size of the objects that can be cooked.Jan 12 2018, 2:38 PM

Revision Contents
Changeset List

Path

Size

swh/

vault/

cookers/

46 lines

tests/

test_cookers_base.py

94 lines

Diff 961

swh/vault/cookers/base.py

Loading...

swh/vault/tests/test_cookers_base.py

Loading...