Differential D2848

Serialize objstorage and database writes in content_add
ClosedPublic
Actions

Authored by olasd on Mar 18 2020, 3:40 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTO209de5dbaa12: Serialize objstorage and database writes in content_add

Summary

Considering that the objstorage is idempotent, and that there's no rollback
feature, intermixing both "transactions" has no concrete benefit. This avoids
doing database transactions that are longer than needed.

Test Plan

tox tests are again unchanged

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Mar 18 2020, 3:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 18 2020, 3:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1068/ for more details.

Harbormaster completed remote builds in B11198: Diff 10131.Mar 18 2020, 3:46 PM

vlorentz accepted this revision.Mar 18 2020, 3:56 PM

This revision is now accepted and ready to land.Mar 18 2020, 3:56 PM

Closed by commit rDSTO209de5dbaa12: Serialize objstorage and database writes in content_add (authored by olasd). · Explain WhyMar 18 2020, 3:58 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTO209de5dbaa12: Serialize objstorage and database writes in content_add.

vlorentz mentioned this in D2248: [WIP] In case of race condition in content_add, raise SerializationFailure instead of HashCollision..Feb 11 2021, 5:44 PM

vlorentz mentioned this in D5246: content_add: Write to the objstorage before the DB or Kafka.Mar 15 2021, 12:56 PM

Revision Contents
Changeset List

Path

Size

swh/

storage/

storage.py

41 lines

Diff 10132

View Options

Serialize objstorage and database writes in content_addClosedPublicActions