tox
Details
- Reviewers
douardda - Group Reviewers
Reviewers - Commits
- rDJNL632f17192c2a: journal.replay: Batch insert contents/skipped_contents
Diff Detail
- Repository
- rDJNL Journal infrastructure
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/349/ for more details.
swh/journal/replay.py | ||
---|---|---|
249 | Do we add a fallback behavior to ensure other objects from the failing transaction are written nonetheless? Sounds sensible to do so (in the mirror context). Maybe we should evolve the hash collision exception to refeerence the content in error. |
swh/journal/replay.py | ||
---|---|---|
249 |
Right now we have HashCollision 'type' of hash collision as message (e.g. sha1)... [1] [1] https://sentry.softwareheritage.org/share/issue/5a6f8c09fea1468997bb88ca3e19fc2d/ |
swh/journal/replay.py | ||
---|---|---|
235–236 | are these vars necessary? Why not simply use (with proper exception handling stuff): storage.skipped_content_add( (obj for obj in objects if obj.get('status') == 'absent')) storage.content_add_metadata( (obj for obj in objects if obj.get('status') != 'absent')) |
swh/journal/replay.py | ||
---|---|---|
235–236 | Depends if we want to act upon my question below or not i guess ;) |
swh/journal/replay.py | ||
---|---|---|
235–236 | Well one thing at a time. Let's deal with this as is, then discuss how to improve cases of ingestion error... |
Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/350/ for more details.