Page MenuHomeSoftware Heritage

in-memory storage: compute all counters
Needs RevisionPublic

Authored by joachimf on Tue, Feb 4, 12:57 PM.

Details

Summary

Hello guys this is my first contribution ;) .

Methods:

  • origin_metadata_add
  • tool_add
  • metadata_provider_add

Now add objects to self._objects so counters return the good value

Related: T1377

Test Plan

Added test in the functions related to the addition

Diff Detail

Repository
rDSTO Storage manager
Branch
compute-all-counters
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10426
Build 15523: tox-on-jenkinsJenkins
Build 15522: arc lint + arc unit

Event Timeline

joachimf created this revision.Tue, Feb 4, 12:57 PM
joachimf edited the summary of this revision. (Show Details)Tue, Feb 4, 12:58 PM
douardda requested changes to this revision.Thu, Feb 6, 10:57 AM
douardda added a subscriber: douardda.

Thanks for the contribution.
You must however ensure tests pass ok before we can accept it. Note that the tests you modify (in tests/test_storage.py) are executed by all the storage backends (postgres, cassandra and the in_memory one you really are targeting here). So make sure they are still OK with all the backends.

This revision now requires changes to proceed.Thu, Feb 6, 10:57 AM

Thanks for the answer I will remove the tests, however I struggle a lot to start the original tests in local for this package.