Page MenuHomeSoftware Heritage
Differential D2533

gunicorn_config: Fix tests after recent changes in swh-core
ClosedPublic
Actions

Authored by anlambert on Jan 15 2020, 1:54 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS13385f20e1b0: tests/gunicorn_config: Fix tests after recent changes in swh-core
Summary

Those tests were broken since rDCORE2255767b9763cefe0841a8d0231f568adcec87ff.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Jan 15 2020, 1:54 PM
swh-public-ci added a comment.Jan 15 2020, 2:00 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/886/ for more details.

anlambert updated this revision to Diff 9012.Jan 15 2020, 2:01 PM

Update: Remove duplicated license header and update copyright years

swh-public-ci added a comment.Jan 15 2020, 2:07 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/887/ for more details.

swh-public-ci added a comment.Jan 15 2020, 2:08 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/494/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/494/console

Harbormaster failed remote builds in B10112: Diff 9010!Jan 15 2020, 2:08 PM
anlambert mentioned this in D2530: Decode textual content from utf-8 before displaying it.Jan 15 2020, 2:16 PM
vlorentz accepted this revision.Jan 15 2020, 2:18 PM

Oops, I forgot that file.

This revision is now accepted and ready to land.Jan 15 2020, 2:18 PM
vlorentz requested changes to this revision.Jan 15 2020, 2:20 PM

Actually, I think it would be cleaner to also stop importing swh.core's post_fork, and call swh.core.sentry.init_sentry instead:

def post_fork(server, worker)
    init_sentry(integrations=[DjangoIntegration()])
This revision now requires changes to proceed.Jan 15 2020, 2:20 PM
swh-public-ci added a comment.Jan 15 2020, 2:20 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/495/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/495/console

Harbormaster failed remote builds in B10114: Diff 9012!Jan 15 2020, 2:20 PM
anlambert updated this revision to Diff 9015.Jan 15 2020, 2:35 PM

Address @vlorentz comment

vlorentz accepted this revision.Jan 15 2020, 2:36 PM
This revision is now accepted and ready to land.Jan 15 2020, 2:36 PM
This revision was landed with ongoing or failed builds.Jan 15 2020, 2:38 PM
Closed by commit rDWAPPS13385f20e1b0: tests/gunicorn_config: Fix tests after recent changes in swh-core (authored by anlambert). · Explain Why
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS13385f20e1b0: tests/gunicorn_config: Fix tests after recent changes in swh-core.
swh-public-ci added a comment.Jan 15 2020, 2:42 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/890/ for more details.

Harbormaster failed remote builds in B10117: Diff 9015!Jan 15 2020, 2:49 PM
swh-public-ci added a comment.Jan 15 2020, 2:49 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/498/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/498/console

anlambert mentioned this in D2544: gunicorn_config: Fix tests after recent changes in swh-core.Jan 16 2020, 6:09 PM

Revision Contents
Changeset List

PathSize
swh/
web/
10 lines
tests/
8 lines

Diff 9016

View Options

swh/web/gunicorn_config.py

Loading...
View Options

swh/web/tests/test_gunicorn_config.py

Loading...
About · Developer information · Legal