Differential D2406

npm: Align lister's loader output tasks with expected format
ClosedPublic
Actions

Authored by ardumont on Dec 6 2019, 4:56 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS5d096d511c0f: npm: Align lister's loader output tasks with expected format

Summary

Related to T2134

Test Plan

tox

Diff Detail

Repository

rDLS Listers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 6 2019, 4:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2019, 4:56 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/508/ for more details.

Harbormaster completed remote builds in B9594: Diff 8511.Dec 6 2019, 4:59 PM

Apart a trailing comma in a function call, looks good !

swh/lister/npm/lister.py
59	trailing comma here

This revision is now accepted and ready to land.Dec 6 2019, 5:03 PM

Fix trailing comma

(thx)

Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/509/ for more details.

Harbormaster completed remote builds in B9595: Diff 8512.Dec 6 2019, 5:11 PM

Closed by commit rDLS5d096d511c0f: npm: Align lister's loader output tasks with expected format (authored by ardumont). · Explain WhyDec 6 2019, 5:17 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDLS5d096d511c0f: npm: Align lister's loader output tasks with expected format.

Revision Contents
Changeset List

Path

Size

swh/

lister/

npm/

lister.py

22 lines

tests/

test_lister.py

10 lines

Diff 8513

View Options

swh/lister/npm/lister.py