Page MenuHomeSoftware Heritage

svn.loader: Migrate to new buffer/filter behavior
ClosedPublic

Authored by ardumont on Dec 6 2019, 2:51 PM.

Details

Summary

This migrates the code to the latest (yet unpublished) loader-core.

Note: build will fail expectedly for now.

Depends D2403

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 6 2019, 2:51 PM
ardumont edited the summary of this revision. (Show Details)Dec 6 2019, 2:53 PM
anlambert accepted this revision.Dec 6 2019, 3:02 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/loader/svn/tests/test_loader.py
38

You can safely remove that entry too as its use is dropped in D2403

This revision is now accepted and ready to land.Dec 6 2019, 3:02 PM
ardumont added inline comments.Dec 6 2019, 3:05 PM
swh/loader/svn/tests/test_loader.py
38

right! thanks!

ardumont updated this revision to Diff 8554.Dec 10 2019, 9:47 AM

Missing update?

ardumont updated this revision to Diff 8613.Dec 12 2019, 12:20 PM

Rebase and plug to master

ardumont updated this revision to Diff 8622.Dec 12 2019, 2:09 PM

Update requirements

ardumont updated this revision to Diff 8623.EditedDec 12 2019, 2:10 PM

Update to the latest bug-free version

This revision was automatically updated to reflect the committed changes.