Page MenuHomeSoftware Heritage
Differential D2398

svn: Unify loader constructor + register worker (tasks, cli)
ClosedPublic
Actions

Authored by ardumont on Dec 5 2019, 2:21 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDLDSVN069f7f5ec224: tasks: Use celery's shared_task decorator
rDLDSVNced8b2704f6e: loader.svn: Register svn worker
rDLDSVN3167054a142e: tests: Migrate to use pytest-mock's mocker fixture
rDLDSVN161e06d30356: svn.tasks: Rename tasks according to production's
rDLDSVN36cd571ee156: tasks: Adapt tasks according to the constructor unification
rDLDSVNa9383662c8ba: svn: Unify loader constructor with url as parameter
Summary

With this, we stop passing parameters to the load method. We pass those
parameters to the loader's constructor.

  • svn.tasks: Adapt tasks according to the constructor unification
  • svn.tasks: Rename tasks according to production's
  • loader.svn: Register svn worker (scheduler task auto-registration + cli auto-registration)

Related to T2134

Depends D2397

Test Plan

tox

Diff Detail

Repository
rDLDSVN Subversion (SVN) loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Dec 5 2019, 2:21 PM
ardumont edited the summary of this revision. (Show Details)Dec 5 2019, 2:22 PM
swh-public-ci added a comment.Dec 5 2019, 2:23 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/42/ for more details.

Harbormaster completed remote builds in B9530: Diff 8451.Dec 5 2019, 2:23 PM
ardumont retitled this revision from svn: Unify loader constructor with url as parameter to svn: Unify loader constructor + auto-register worker (tasks, cli).Dec 5 2019, 2:28 PM
ardumont retitled this revision from svn: Unify loader constructor + auto-register worker (tasks, cli) to svn: Unify loader constructor + register worker (tasks, cli).Dec 5 2019, 3:15 PM
ardumont mentioned this in T2134: loader: Implement uniform loading CLI.Dec 6 2019, 10:04 AM
anlambert accepted this revision.Dec 6 2019, 1:36 PM
anlambert added a subscriber: anlambert.

Looks good !

swh/loader/svn/__init__.py
9 ↗(On Diff #8451)

s/Mapping/Dict/

swh/loader/svn/tasks.py
1

2019

swh/loader/svn/tests/test_task.py
6 ↗(On Diff #8451)

You should use the mocker fixture from pytest-mock here instead:

def test_svn_loader(
        mocker, swh_app, celery_session_worker, swh_config):
    mock_loader = mocker.patch('swh.loader.svn.loader.SvnLoader.load')
    mock_loader.return_value = {'status': 'eventful'}
This revision is now accepted and ready to land.Dec 6 2019, 1:36 PM
anlambert mentioned this in D2399: mercurial: Unify loader constructor + register worker (tasks, cli).Dec 6 2019, 1:46 PM
ardumont added inline comments.Dec 6 2019, 1:57 PM
swh/loader/svn/tests/test_task.py
6 ↗(On Diff #8451)

Thanks.
Will look into that.

https://pypi.org/project/pytest-mock/

ardumont updated this revision to Diff 8486.Dec 6 2019, 2:45 PM

Adapt according to review

swh-public-ci added a comment.Dec 6 2019, 2:47 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/43/ for more details.

Harbormaster completed remote builds in B9569: Diff 8486.Dec 6 2019, 2:47 PM
Closed by commit rDLDSVNa9383662c8ba: svn: Unify loader constructor with url as parameter (authored by ardumont). · Explain WhyDec 6 2019, 2:47 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDLDSVNa9383662c8ba: svn: Unify loader constructor with url as parameter.
ardumont added a commit: rDLDSVN36cd571ee156: tasks: Adapt tasks according to the constructor unification.
ardumont added a commit: rDLDSVN161e06d30356: svn.tasks: Rename tasks according to production's.
ardumont added a commit: rDLDSVNced8b2704f6e: loader.svn: Register svn worker.
ardumont added a commit: rDLDSVN3167054a142e: tests: Migrate to use pytest-mock's mocker fixture.
ardumont added a commit: rDLDSVN069f7f5ec224: tasks: Use celery's shared_task decorator.

Revision Contents
Changeset List

PathSize
swh/
loader/
svn/
78 lines
9 lines
tests/
154 lines

Diff 8487

View Options

swh/loader/svn/loader.py

Loading...
View Options

swh/loader/svn/tasks.py

Loading...
View Options

swh/loader/svn/tests/test_loader.py

Loading...
About · Developer information · Legal