Differential D2334

Use pkg_resources to get the package version instead of vcversioner
ClosedPublic
Actions

Authored by olasd on Nov 21 2019, 5:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE681385814f05: Use pkg_resources to get the package version instead of vcversioner

Summary

The vcversioner feature of generating _version.py wasn't enabled anyway, so the
version was always reported as 'devel'. Oops.

I guess that's a step towards T2105

Test Plan

tox

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Nov 21 2019, 5:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2019, 5:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/242/ for more details.

Harbormaster completed remote builds in B9310: Diff 8044.Nov 21 2019, 6:00 PM

ardumont accepted this revision.Nov 21 2019, 6:07 PM

This revision is now accepted and ready to land.Nov 21 2019, 6:07 PM

Use proper exception for pkg_resources

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/243/ for more details.

Harbormaster completed remote builds in B9311: Diff 8045.Nov 21 2019, 6:11 PM

Closed by commit rDLDBASE681385814f05: Use pkg_resources to get the package version instead of vcversioner (authored by olasd). · Explain WhyNov 21 2019, 6:27 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDLDBASE681385814f05: Use pkg_resources to get the package version instead of vcversioner.

Revision Contents
Changeset List

Path

Size

swh/

loader/

package/

__init__.py

7 lines

tests/

test_utils.py

27 lines

Diff 8048

View Options

swh/loader/package/init.py

View Options

swh/loader/package/tests/test_utils.py

Use pkg_resources to get the package version instead of vcversionerClosedPublicActions