Page MenuHomeSoftware Heritage
Differential D2285

Truncate result list instead of doing a copy.
ClosedPublic
Actions

Authored by vlorentz on Nov 15 2019, 2:46 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDX17dc3c70dac2: Truncate result list instead of doing a copy.
Summary

A quick poll on IRC showed this was more popular (sample size=3, myself included)

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Nov 15 2019, 2:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptNov 15 2019, 2:46 PM
vlorentz updated this revision to Diff 7858.Nov 15 2019, 2:47 PM

remove change that wasn't supposed to be committed.

vlorentz updated this revision to Diff 7859.Nov 15 2019, 2:48 PM

uniformity

swh-public-ci added a comment.Nov 15 2019, 2:48 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/657/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/657/console

Harbormaster failed remote builds in B9046: Diff 7857!Nov 15 2019, 2:48 PM
swh-public-ci added a comment.Nov 15 2019, 2:50 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/658/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/658/console

Harbormaster failed remote builds in B9047: Diff 7858!Nov 15 2019, 2:50 PM
swh-public-ci added a comment.Nov 15 2019, 2:52 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/659/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/659/console

Harbormaster failed remote builds in B9048: Diff 7859!Nov 15 2019, 2:52 PM
vlorentz updated this revision to Diff 7861.Nov 15 2019, 3:11 PM

off-by-one error

swh-public-ci added a comment.Nov 15 2019, 3:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/660/ for more details.

Harbormaster completed remote builds in B9050: Diff 7861.Nov 15 2019, 3:13 PM
ardumont accepted this revision.Nov 18 2019, 10:31 AM
This revision is now accepted and ready to land.Nov 18 2019, 10:31 AM
Closed by commit rDCIDX17dc3c70dac2: Truncate result list instead of doing a copy. (authored by vlorentz). · Explain WhyNov 19 2019, 4:14 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDX17dc3c70dac2: Truncate result list instead of doing a copy..

Revision Contents
Changeset List

PathSize
swh/
indexer/
storage/
6 lines

Diff 7914

View Options

swh/indexer/storage/__init__.py

Loading...
About · Developer information · Legal