Page MenuHomeSoftware Heritage

typing: minimal changes to make a no-op mypy run pass
ClosedPublic

Authored by anlambert on Nov 5 2019, 3:51 PM.

Details

Test Plan

tox -e mypy

Currently, mypy checks will fail as new tags including the typing info for swh-vault
and swh-indexer need to be created.

This should be landed once it is done.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 5 2019, 3:51 PM
anlambert updated this revision to Diff 7656.Nov 5 2019, 4:05 PM

Update: Modify test command in tox.ini for mypy env

anlambert updated this revision to Diff 7657.Nov 5 2019, 4:08 PM

Fix rebase

anlambert updated this revision to Diff 7659.Nov 5 2019, 4:12 PM

Update tox.ini again for setting DJANGO_SETTINGS_MODULE

Unfortunately, the mypy_django_plugin fails to load in tox when using Python 3.5 while it loads correctly when using Python 3.7.

So me must also wait for the CI environment to be upgraded to buster before landing this.

zack accepted this revision.Nov 5 2019, 5:26 PM

I'm approving this as it LGTM, but indeed we should wait for the CI update to 3.7 before merging.

This revision is now accepted and ready to land.Nov 5 2019, 5:26 PM
zack added a comment.Nov 5 2019, 5:48 PM

Currently, mypy checks will fail as new tags including the typing info for swh-vault and swh-indexer need to be created.

I've just released both of them.

This revision was automatically updated to reflect the committed changes.