Page MenuHomeSoftware Heritage
Differential D2220

typing: minimal changes to make a no-op mypy run pass
ClosedPublic
Actions

Authored by anlambert on Nov 5 2019, 3:51 PM.

Details

Reviewers
zack
Group Reviewers
Reviewers
Commits
rDWAPPS8509d40153c0: typing: minimal changes to make a no-op mypy run pass
Test Plan

tox -e mypy

Currently, mypy checks will fail as new tags including the typing info for swh-vault
and swh-indexer need to be created.

This should be landed once it is done.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Nov 5 2019, 3:51 PM
swh-public-ci added a comment.Nov 5 2019, 3:53 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/753/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/753/console

Harbormaster failed remote builds in B8820: Diff 7653!Nov 5 2019, 3:53 PM
swh-public-ci added a comment.Nov 5 2019, 3:55 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/355/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/355/console

anlambert updated this revision to Diff 7656.Nov 5 2019, 4:05 PM

Update: Modify test command in tox.ini for mypy env

Harbormaster failed remote builds in B8823: Diff 7656!Nov 5 2019, 4:05 PM
swh-public-ci added a comment.Nov 5 2019, 4:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/357/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/357/console

swh-public-ci added a comment.Nov 5 2019, 4:06 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/755/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/755/console

anlambert updated this revision to Diff 7657.Nov 5 2019, 4:08 PM

Fix rebase

swh-public-ci added a comment.Nov 5 2019, 4:10 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/756/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/756/console

Harbormaster failed remote builds in B8824: Diff 7657!Nov 5 2019, 4:10 PM
anlambert updated this revision to Diff 7659.Nov 5 2019, 4:12 PM

Update tox.ini again for setting DJANGO_SETTINGS_MODULE

swh-public-ci added a comment.Nov 5 2019, 4:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/358/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/358/console

swh-public-ci added a comment.Nov 5 2019, 4:15 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/757/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/757/console

Harbormaster failed remote builds in B8826: Diff 7659!Nov 5 2019, 4:15 PM
swh-public-ci added a comment.Nov 5 2019, 4:16 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/359/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/359/console

anlambert added a comment.Nov 5 2019, 5:16 PM

Unfortunately, the mypy_django_plugin fails to load in tox when using Python 3.5 while it loads correctly when using Python 3.7.

So me must also wait for the CI environment to be upgraded to buster before landing this.

zack accepted this revision.Nov 5 2019, 5:26 PM

I'm approving this as it LGTM, but indeed we should wait for the CI update to 3.7 before merging.

This revision is now accepted and ready to land.Nov 5 2019, 5:26 PM
zack added a comment.Nov 5 2019, 5:48 PM

Currently, mypy checks will fail as new tags including the typing info for swh-vault and swh-indexer need to be created.

I've just released both of them.

swh-public-ci added a comment.Nov 5 2019, 5:50 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/758/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/758/console

swh-public-ci added a comment.Nov 6 2019, 5:16 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/759/ for more details.

swh-public-ci added a comment.Nov 6 2019, 5:22 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/360/ for more details.

Harbormaster completed remote builds in B8826: Diff 7659.Nov 6 2019, 5:22 PM
anlambert updated this revision to Diff 7676.Nov 6 2019, 5:29 PM

Rebase

swh-public-ci added a comment.Nov 6 2019, 5:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/760/ for more details.

swh-public-ci added a comment.Nov 6 2019, 5:39 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/361/ for more details.

Harbormaster completed remote builds in B8844: Diff 7676.Nov 6 2019, 5:39 PM
Closed by commit rDWAPPS8509d40153c0: typing: minimal changes to make a no-op mypy run pass (authored by zack, committed by anlambert). · Explain WhyNov 6 2019, 5:43 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS8509d40153c0: typing: minimal changes to make a no-op mypy run pass.

Revision Contents
Changeset List

PathSize
1 line
1 line
8 lines
49 lines
1 line
swh/
5 lines
web/
admin/
4 lines
20 lines
api/
5 lines
common/
6 lines
migrations/
3 lines
6 lines
4 lines
1 line
settings/
2 lines
tests/
9 lines
11 lines

Diff 7678

View Options

.gitignore

Loading...
View Options

MANIFEST.in

Loading...
View Options

Makefile.local

Loading...
View Options

mypy.ini

Loading...
View Options

requirements-test.txt

Loading...
View Options

swh/__init__.py

Loading...
View Options

swh/web/admin/deposit.py

Loading...
View Options

swh/web/admin/origin_save.py

Loading...
View Options

swh/web/api/apiurls.py

Loading...
View Options

swh/web/common/highlightjs.py

Loading...
View Options

swh/web/common/migrations/0001_initial.py

Loading...
View Options

swh/web/common/urlsindex.py

Loading...
View Options

swh/web/config.py

Loading...
View Options

swh/web/py.typed

Loading...
View Options

swh/web/settings/tests.py

Loading...
View Options

swh/web/tests/data.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal