tox -e mypy
Currently, mypy checks will fail as new tags including the typing info for swh-vault
and swh-indexer need to be created.
This should be landed once it is done.
Details
Details
- Reviewers
zack - Group Reviewers
Reviewers - Commits
- rDWAPPS8509d40153c0: typing: minimal changes to make a no-op mypy run pass
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/753/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/753/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/355/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/355/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/357/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/357/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/755/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/755/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/756/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/756/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/358/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/358/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/757/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/757/console
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/359/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/359/console
Comment Actions
Unfortunately, the mypy_django_plugin fails to load in tox when using Python 3.5 while it loads correctly when using Python 3.7.
So me must also wait for the CI environment to be upgraded to buster before landing this.
Comment Actions
I'm approving this as it LGTM, but indeed we should wait for the CI update to 3.7 before merging.
Comment Actions
Currently, mypy checks will fail as new tags including the typing info for swh-vault and swh-indexer need to be created.
I've just released both of them.
Comment Actions
Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/758/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/758/console
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/759/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/360/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/760/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/361/ for more details.