Page MenuHomeSoftware Heritage

(tryout fix build patch for D2145) storage.storage: Allow the origin.type column to be None
AbandonedPublic

Authored by ardumont on Oct 17 2019, 6:20 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Summary

Turns out in the postgresql schema, there is no "not null" constraint
on the origin.type column already.

It's not a real fix (well i did not test it thorougly, i just know local tests
are fine), it's just a tryout to make the D2145 build pass.

Note: I don't know if jenkins knows how to cross-build (in-between
repositories) patches though.

Test Plan

tox

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8528
Build 12388: tox-on-jenkinsJenkins
Build 12387: arc lint + arc unit

Event Timeline

ardumont created this revision.Oct 17 2019, 6:20 PM
ardumont retitled this revision from storage.storage: Allow the type to be None to (tryout fix build patch for D2145) storage.storage: Allow the origin.type column to be None.Oct 17 2019, 6:21 PM

Well storage tests are fine...
But the diff D2145 fails nonetheless, /me is sad.

ardumont abandoned this revision.Oct 18 2019, 10:17 AM