Differential D2141

Add a command-line too to run metadata translation.
ClosedPublic
Actions

Authored by vlorentz on Oct 15 2019, 1:37 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDCIDX1d625af0ba1e: Add a command-line tool to run metadata translation.

Summary

We might use it in the hackathon later today

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Oct 15 2019, 1:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 15 2019, 1:37 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/629/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/629/console

Harbormaster failed remote builds in B8463: Diff 7246!Oct 15 2019, 1:37 PM

ardumont requested changes to this revision.Oct 15 2019, 2:11 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/cli.py
97	looks like it's not meant to stay, is it (you use click.echo further down the line).
220	why does it go away? The description mentions adding something, not dropping something.
254	Weren't those removed some time ago?

This revision now requires changes to proceed.Oct 15 2019, 2:11 PM

remove print
remove stuff that wasn't supposed to be committed

Because I messed up git. Removed

ardumont accepted this revision.Oct 15 2019, 2:35 PM

This revision is now accepted and ready to land.Oct 15 2019, 2:35 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/630/ for more details.

Harbormaster completed remote builds in B8469: Diff 7253.Oct 15 2019, 2:35 PM

Closed by commit rDCIDX1d625af0ba1e: Add a command-line tool to run metadata translation. (authored by vlorentz). · Explain WhyOct 15 2019, 2:50 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX1d625af0ba1e: Add a command-line tool to run metadata translation..

Revision Contents
Changeset List

Path

Size

swh/

indexer/

17 lines

Diff 7254

swh/indexer/cli.py

Loading...