Page MenuHomeSoftware Heritage

Enable iteration on the graph
AbandonedPublic

Authored by seirl on Oct 11 2019, 5:37 PM.

Details

Diff Detail

Repository
rDGRPH Compressed graph representation
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 11 2019, 6:01 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
douardda added a subscriber: douardda.
douardda added inline comments.
swh/graph/tests/test_pid.py
149

This lacks a (series of) test(s) for the iter_prefix() method.

Sure this is indirectly tested vie this test, but it should be tested as is. One may find it clever to reimplement iter_type without using iter_prefix, for example.

This revision now requires changes to proceed.Oct 14 2019, 4:05 PM
seirl added inline comments.
swh/graph/tests/test_pid.py
149

Thanks, this is fixed in master. I'm closing this diff.

seirl marked an inline comment as done.