vault: WIP database backend
Details
Details
- Reviewers
- None
- Commits
- rDVAUac55b63f4f48: backend: fix database accesses
rDVAU1b70c451ebc7: backend: prettier e-mail
rDVAUc23245680616: revision_git: update progress_msg
rDVAUadcb7bffa31c: backend: fix cooking task name
rDVAUffadfc6ce0c3: cooking_tasks: use run_task() from swh.scheduler
rDVAU01bd532aebf6: setup.py: update from storage to vault
rDVAU472fd70fd796: api: add email field
rDVAU7d4bdd43a9c4: backend: fix db api
rDVAU0b97fb3b1d8c: cookers: rename revision_git to revision_gitfast
rDVAUbe4c8f5811ca: cookers: remove circular import in __init__.py
rDVAU45bf2b4bfe56: cooking_tasks: change celery queue name
rDVAU4204680c9733: requirements: python-fastimport module was renamed to fastimport
rDVAU8f3d53827558: vault: use uuid as schema type for celery uuid
rDVAUe5bde0383bfa: vault: fix tuple passing to cursor.execute()
rDVAU26e342857308: vault: initial notification system
rDVAUd99077b5abb5: vault: initial database backend
rDVAU82c1ca0a52c3: sql: add schema
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
just briefly reviewed the SQL schema, adding minor comments
| sql/swh-vault-schema.sql | ||
|---|---|---|
| 13–14 | This is the type of the cooking *format*, right? (just a nit, of course) | |
| 32 | not sure what this is, if it's progress info why it's in the DB and isn't task_status enough? if it's actually needed, a comment describing what this is for in the SQL would be nice :-) | |
| sql/swh-vault-schema.sql | ||
|---|---|---|
| 13–14 | It's not exactly the format, it's the format AND the type. for instance: directory, revision_gitfast, revision_hgbundle, snapshot_gitfast... | |
| 32 | status is just a way of checking whether the bundle is new, pending or done. progress is arbitrary data the cookers can fill to describe their progress, like "[phase 1/6] sorting revisions (54764/978784112)". | |
Comment Actions
- requirements: python-fastimport module was renamed to fastimport
- vault schema: fixup sql syntax
- cooking_tasks: change celery queue name
Comment Actions
- cookers: rename revision_git to revision_gitfast
- cookers: remove circular import in __init__.py
- backend: fix db api
- api: add email field
Comment Actions
- vault: initial database backend
- vault: initial notification system
- vault: fix tuple passing to cursor.execute()
- vault: use uuid as schema type for celery uuid
- requirements: python-fastimport module was renamed to fastimport
- cooking_tasks: change celery queue name
- cookers: rename revision_git to revision_gitfast
- cookers: remove circular import in __init__.py
- backend: fix db api
- api: add email field
- setup.py: update from storage to vault
- cooking_tasks: use run_task() from swh.scheduler
- backend: fix cooking task name
- backend: fix database accesses
- backend: prettier e-mail