Page MenuHomeSoftware Heritage

requests: Set timeout to prevent hangs when querying external services
ClosedPublic

Authored by anlambert on Tue, Oct 1, 4:41 PM.

Details

Summary

Set timeout parameter when querying external services through the requests module.
This will prevent possible hangs of swh-web backend when a connection is made to
a service but no data is received.

Related T2028

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Tue, Oct 1, 4:41 PM
olasd accepted this revision.Tue, Oct 1, 5:45 PM

Sounds like a good first fix, thanks.

This revision is now accepted and ready to land.Tue, Oct 1, 5:45 PM