Page MenuHomeSoftware Heritage

pathslicing: add {add,get}_stream methods
AbandonedPublic

Authored by seirl on Apr 4 2017, 3:13 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Summary

this is only for the pathslicing object for now as the remote client
requires a rewrite with aiohttp (this is why it's still undocumented and not
part of the base class, those will be added once the remote api is able to
stream objects)

Diff Detail

Repository
rDOBJS Object storage
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 850
Build 1140: arc lint + arc unit

Event Timeline

olasd requested changes to this revision.Apr 4 2017, 3:36 PM
olasd added a subscriber: olasd.

Looks reasonable, although I don't really like the functools.partial + iter style and would much rather have an explicit loop.

Tests ?

swh/objstorage/objstorage_pathslicing.py
230

It might be more natural to swap the obj_id and content_iter arguments here?

This revision now requires changes to proceed.Apr 4 2017, 3:36 PM