Page MenuHomeSoftware Heritage

Document that 'snapshot' may be null if visit status!=full.
ClosedPublic

Authored by vlorentz on Tue, Aug 27, 6:06 PM.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Tue, Aug 27, 6:06 PM
vlorentz updated this revision to Diff 6433.Tue, Aug 27, 6:07 PM

formatting

Visits with partial status does not necessarily imply that the associated snapshot will be null, see below:

softwareheritage=> select * from origin_visit where status = 'partial' and snapshot is not NULL limit 100;
  origin  | visit |             date              | status  | metadata |                  snapshot                  | type 
----------+-------+-------------------------------+---------+----------+--------------------------------------------+------
 57705992 |     9 | 2016-05-03 15:16:32+00        | partial |          | \x433f0a671a1b719604d8517fec91790ffde07097 | svn
 84962492 |    11 | 2018-12-02 18:17:38.537705+00 | partial |          | \x52ca1dbb44cc0347eae18375b63f7ed34c7311f1 | pypi
 84992717 |     8 | 2018-12-02 18:24:33.126591+00 | partial |          | \x4d3c276a6f1b8a9ce40f495387cd161f0ab38743 | pypi
 89097540 |     2 | 2019-06-16 06:51:36.933109+00 | partial |          | \x657f76ab60e50688530a20ebabba87c2f9862502 | npm
 89100082 |     2 | 2019-06-16 06:53:23.760365+00 | partial |          | \x7a0035b5393546e61f378a93110ee3765f565dbf | npm
 89099592 |     2 | 2019-06-16 06:53:26.271626+00 | partial |          | \xc62d3a13fd2c4fbfa2a70b52af1ee45276dc3b60 | npm
 89099688 |     2 | 2019-06-16 06:53:27.594598+00 | partial |          | \x9a563a6b24b2ce23b0040443b991c7d28366b4c9 | npm
 89099682 |     2 | 2019-06-16 06:53:30.111047+00 | partial |          | \xefb8b0035c9af41b75de5b4664dda31e423d87ba | npm
 84947014 |    16 | 2018-12-02 18:36:38.644482+00 | partial |          | \xaf2076d979215d54f508e7ba30c6dc3743a77092 | pypi
 89099990 |     2 | 2019-06-16 06:56:53.548095+00 | partial |          | \xb24822756fac9a1b0850e9b8e4b18f9ae1009a74 | npm
 58258818 |     8 | 2016-05-03 15:16:32+00        | partial |          | \x40e964e7114691f6d752172a1db3760c5a24800c | svn
 89100451 |     2 | 2019-06-16 06:58:54.891492+00 | partial |          | \xbbbeac0bd1e880ab90ba24e00f8b05ed21d36b73 | npm
 84962098 |    11 | 2018-12-02 18:42:15.175185+00 | partial |          | \xea5362a2321dc254a7252439a65176c3049fddde | pypi
 84945041 |    16 | 2018-12-02 18:42:18.000849+00 | partial |          | \xf0f37bcb064d4bf7f0fd546c9f779462be707564 | pypi
 84947267 |    16 | 2018-12-02 18:42:31.059778+00 | partial |          | \x9e742214a3193524a675ab91d14241b57a0ac11e | pypi
 84991411 |     8 | 2018-12-02 18:43:01.2561+00   | partial |          | \xf4759f45acf385d76a895888cee416745a57a3c4 | pypi
 89103216 |     2 | 2019-06-16 07:47:37.230747+00 | partial |          | \x8072a0a2ebfd1c6a403503a8eaa2833ce0d41dfd | npm
 85025973 |     6 | 2018-12-02 18:58:39.400478+00 | partial |          | \x6a5b15ca9890d4facbc0f86e3dc35398851ec2a5 | pypi

(or null if status is not full) => (can be null if status is not full)

anlambert requested changes to this revision.Wed, Aug 28, 3:36 PM

See my last comment.

This revision now requires changes to proceed.Wed, Aug 28, 3:36 PM
anlambert accepted this revision.Thu, Aug 29, 3:49 PM
This revision is now accepted and ready to land.Thu, Aug 29, 3:49 PM
This revision was automatically updated to reflect the committed changes.