I now notice that there is a bunch of directory_cooker variables pointing to instances of DirectoryBuilder which is confusing and should be fixed in a further round. Also one comment inline.

swh/storage/vault/api/client.py
18	That should stay as `self.get` now that the (involuntary?) override has been fixed below

This revision is now accepted and ready to land.Mar 9 2017, 2:45 PM

fix super().get() -> self.get()

seirl marked an inline comment as done.Mar 9 2017, 3:27 PM

Harbormaster completed remote builds in B750: Diff 586.Mar 9 2017, 3:27 PM

Closed by commit rDSTO7e15b4b92085: vault: move cookers into separate files (authored by seirl). · Explain WhyMar 9 2017, 3:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

storage/

vault/

api/

2 lines

2 lines

2 lines

cookers/

12 lines

39 lines

49 lines

	cookers/

	base.py
	cooker.py

90 lines

Diff 587

View Options

swh/storage/vault/api/client.py

View Options

swh/storage/vault/api/cooking_tasks.py

View Options

swh/storage/vault/api/server.py

View Options

swh/storage/vault/cooker.py

View Options

swh/storage/vault/cookers/init.py

View Options

swh/storage/vault/cookers/base.py

View Options

swh/storage/vault/cookers/directory.py

View Options

swh/storage/vault/cookers/revision_flat.py

vault: move cookers into separate filesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 587

swh/storage/vault/api/client.py

swh/storage/vault/api/cooking_tasks.py

swh/storage/vault/api/server.py

swh/storage/vault/cooker.py

swh/storage/vault/cookers/__init__.py

swh/storage/vault/cookers/base.py

swh/storage/vault/cookers/directory.py

swh/storage/vault/cookers/revision_flat.py

vault: move cookers into separate files
ClosedPublic
Actions

Revision Contents
Changeset List

swh/storage/vault/cookers/init.py