server: remove unnecessary 'visited.fill(false)' call
ClosedPublic
Actions

Authored by haltode on Aug 19 2019, 3:44 PM.

Details

Reviewers

zack
seirl

Commits

rDGRPH101c50f2f10e: server: remove unnecessary 'visited.fill(false)' call

Summary

This was creating a fixed overhead in the benchmarks. The bit vector is
by default initialized with false when instantiated.

Diff Detail

Repository

rDGRPH Compressed graph representation

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Aug 19 2019, 3:44 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/19/
See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/19/console

Harbormaster failed remote builds in B7302: Diff 6266!Aug 19 2019, 3:46 PM

zack accepted this revision.Aug 19 2019, 5:37 PM

This revision is now accepted and ready to land.Aug 19 2019, 5:37 PM

This revision was landed with ongoing or failed builds.Aug 19 2019, 5:40 PM

Closed by commit rDGRPH101c50f2f10e: server: remove unnecessary 'visited.fill(false)' call (authored by haltode). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

java/

server/

src/

main/

java/

org/

softwareheritage/

graph/

algo/

Traversal.java

4 lines

Diff 6279

View Options

java/server/src/main/java/org/softwareheritage/graph/algo/Traversal.java

server: remove unnecessary 'visited.fill(false)' callClosedPublicActions