Page MenuHomeSoftware Heritage

Add vault use-case benchmark
ClosedPublic

Authored by haltode on Aug 14 2019, 10:55 AM.

Diff Detail

Repository
rDGRPH Graph service
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

haltode created this revision.Aug 14 2019, 10:55 AM
zack accepted this revision.Aug 14 2019, 11:50 AM

I'm approving this as it's good enough. But please make the seed a real random seed rather than hard coded (in a subsequent commit). It's *useful* to have a fixed seed for reproducibility, but it should not be the default and it should be possible to pass it externally, e.g., as a class parameter and/or CLI option.

This revision is now accepted and ready to land.Aug 14 2019, 11:50 AM
This revision was landed with ongoing or failed builds.Aug 14 2019, 1:24 PM
This revision was automatically updated to reflect the committed changes.

As told on IRC, I was waiting on adding all benchmarking interfaces before implementing the CLI options.