Page MenuHomeSoftware Heritage

cypress: Add tests for visits
ClosedPublic

Authored by kalpitk on Thu, Jul 25, 9:07 PM.

Details

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kalpitk created this revision.Thu, Jul 25, 9:07 PM
kalpitk updated this revision to Diff 6008.Fri, Jul 26, 9:31 PM
  • add test
kalpitk updated this revision to Diff 6026.Mon, Jul 29, 4:28 PM

Refactor and add tests

@kalpitk , can you rebase that diff on origin/master. I can not arc patch it locally otherwise.

kalpitk retitled this revision from [WIP] Add tests for visits to Add tests for visits.Mon, Jul 29, 7:23 PM
kalpitk retitled this revision from Add tests for visits to cypress: Add tests for visits.Mon, Jul 29, 7:27 PM
anlambert accepted this revision.Tue, Jul 30, 12:01 PM

Looks good to me. Just a small nitpick: can you rename the cypress test file to origin-visits.spec.js before landing this.

This revision is now accepted and ready to land.Tue, Jul 30, 12:01 PM
kalpitk updated this revision to Diff 6029.Tue, Jul 30, 12:24 PM

Rename visits -> origin-visits

kalpitk updated this revision to Diff 6030.Tue, Jul 30, 12:32 PM

minor changes

kalpitk added inline comments.Tue, Jul 30, 12:34 PM
cypress/integration/origin-visits.spec.js
24

@anlambert Added this to prevent tests from failing when the visit is filtered out.

anlambert added inline comments.Tue, Jul 30, 1:31 PM
cypress/integration/origin-visits.spec.js
24

Right, this should indeed avoid possible errors. Let's land this !

This revision was automatically updated to reflect the committed changes.