Differential D1746

Add a 'metadata' field to releases.
ClosedPublic
Actions

Authored by vlorentz on Jul 18 2019, 10:52 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDMODa92af53b64e1: Add a 'metadata' field to releases.

Summary

Loaders use it, but it is ignored by the pg storage.
However, as the Cassandra storage uses swh-model to validate
its input, it refuses this input from the loaders (and journal).

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 18 2019, 10:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 18 2019, 10:52 AM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/96/ for more details.

Harbormaster completed remote builds in B6910: Diff 5874.Jul 18 2019, 10:53 AM

Loaders use it, but it is ignored by the pg storage.

Rapidly checking, i saw loader-mercurials sets a default release with 'metadata' to None, that is the culprit.
We discuss the possibility to add those metadata to release some time ago anyway...

So fine, accepting.

This revision is now accepted and ready to land.Jul 18 2019, 12:22 PM

rebase

This revision was landed with ongoing or failed builds.Jul 18 2019, 12:25 PM

Closed by commit rDMODa92af53b64e1: Add a 'metadata' field to releases. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6915: Diff 5880!Jul 18 2019, 12:25 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tox/98/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tox/98/console