Paths

Table of Contentst

Differential D1745

Make the replayer adapt from older formats.
ClosedPublic
Actions

Authored by vlorentz on Jul 18 2019, 10:21 AM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDJNL5f2032bd6a44: Make the replayer adapt from older formats.

Diff Detail

Repository

rDJNL Journal infrastructure

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 18 2019, 10:21 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 18 2019, 10:21 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/181/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/181/console

Harbormaster failed remote builds in B6907: Diff 5872!Jul 18 2019, 10:23 AM

Ok with this, but it would make sense to have tests for these different configurations of 'old formats' I guess...

This revision is now accepted and ready to land.Jul 18 2019, 10:24 AM

Indeed!

add tests

This revision is now accepted and ready to land.Jul 18 2019, 10:50 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/182/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/182/console

Harbormaster failed remote builds in B6909: Diff 5873!Jul 18 2019, 10:52 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/183/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/183/console

douardda requested changes to this revision.Jul 18 2019, 11:31 AM

douardda added inline comments.

swh/journal/tests/test_replay.py
137–150	why don't we know at this point which version of the visits "format" are to be expected?
154	please add a simple doctring/comment to spot the difference with the other version of the test. Or may be these 2 test functions could be factorized somehow?

This revision now requires changes to proceed.Jul 18 2019, 11:31 AM

vlorentz added inline comments.Jul 18 2019, 11:35 AM

swh/journal/tests/test_replay.py
137–150	It currently depends on the value of `SWH_STORAGE_IN_MEMORY_ENABLE_ORIGIN_IDS`.

Docstrings for the tests.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/184/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/184/console

Harbormaster failed remote builds in B6911: Diff 5876!Jul 18 2019, 11:37 AM

douardda added inline comments.Jul 18 2019, 11:45 AM

swh/journal/tests/test_replay.py
137–150	Ok so this should either be mentioned as a comment in there, or (preferred solution I guess) tested with against both values of this flag.

Switch assertions on ENABLE_ORIGIN_IDS.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/185/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/185/console

Harbormaster failed remote builds in B6913: Diff 5878!Jul 18 2019, 11:58 AM

douardda accepted this revision.Jul 18 2019, 12:11 PM

This revision is now accepted and ready to land.Jul 18 2019, 12:11 PM

Build is green
See https://jenkins.softwareheritage.org/job/DJNL/job/tox/186/ for more details.

Harbormaster completed remote builds in B6913: Diff 5878.Jul 18 2019, 12:22 PM

remove code that wasn't supposed to be committed.

This revision was landed with ongoing or failed builds.Jul 18 2019, 12:30 PM

Closed by commit rDJNL5f2032bd6a44: Make the replayer adapt from older formats. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B6917: Diff 5882!Jul 18 2019, 12:30 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DJNL/job/tox/187/
See console output for more information: https://jenkins.softwareheritage.org/job/DJNL/job/tox/187/console

Revision Contents
Changeset List

Path

Size

swh/

journal/

3 lines

21 lines

tests/

96 lines

test_write_replay.py

44 lines

45 lines

Diff 5883

swh/journal/client.py

Loading...

swh/journal/replay.py

Loading...

swh/journal/tests/test_replay.py

Loading...

swh/journal/tests/test_write_replay.py

Loading...

swh/journal/tests/utils.py

Loading...