Here we can't put this @requests_mock.Mocker() on top of the class because of Gitlab lister.

The bad_api_response_file is used when the req_index is not equal to first index. But for simple lister, there is nothing such as index, so I am not able to understand on what condition shall I use bad_api_response_file

I am not sure what these tests do, so I have not added docstring here. I think they test the indexing property of the lister. Am I correct?

Change the comment prior to the method into a docstring.

As lister.task_dict does not have side-effects (as in for example, api call, write to files, etc...), you can call directly it and check the output.

That'd simplify the test here.

# given (<- usually assertion definitions here)
expected_task = {
...
}

# when (<- function or code to actually test, only 1 instruction usual to make stuff clearer)
actual_task = lister.task_dict(...)

# then (<- as many checks as you want)
self.assertEqual(actual_task, expected_task)

There is a funny thing happening when I am putting doccsting to the method.
As soon as I add triple backquotes, flake8 gives an error that as mock_create_tasks:(line 58) is over intended.

Not sure either, the thing is, they do not check anything at the end...
That's wrong.

Yes, that's another issue though.

If you remove the with patch as stated just below, you should not have the problem anymore.

Also, once in a while, it's ok to use # noqa at the end of the statement to make flake8 silent so, that could become:

with patch .... as mock_create_tasks:  # noqa
...

But i'd prefer you simplify the test to the suggestion below.

Please add a fixme after fl.run and we'll be done with it.
Something like:

# FIXME: Determine what this method tries to test and add checks to actually test

Same goes for the test_fetch_one_nodb.

well, no bad response then ;)

I don't think we can do it because the output of task_dict has a datetime object of current date.

{'policy': 'recurring', 'type': 'load-pypi', 'next_run': datetime.datetime(2019, 7, 18, 11, 33, 46, 211689, tzinfo=datetime.timezone.utc), 'arguments': {'args': ('test_pack', 'https://abc'), 'kwargs': {'project_metadata_url': 'https://def'}}}

Now two things can be done

1. Either we remove the datetime object from the actual_task output and then compare
2. Leave this test as it is (ie with mock_create_task and all that)

Which option shall I choose ?