Page MenuHomeSoftware Heritage
Differential D1731

Make origin_get ignore the `type` argument
ClosedPublic
Actions

Authored by vlorentz on Jul 12 2019, 3:25 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTOC7053da801fb4: Make origin_get ignore the `type` argument
rDSTO7053da801fb4: Make origin_get ignore the `type` argument

Diff Detail

Repository
rDSTO Storage manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jul 12 2019, 3:25 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 12 2019, 3:25 PM
swh-public-ci added a comment.Jul 12 2019, 3:29 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/553/ for more details.

Harbormaster completed remote builds in B6852: Diff 5812.Jul 12 2019, 3:29 PM
ardumont requested changes to this revision.Jul 15 2019, 3:00 PM
ardumont added a subscriber: ardumont.

This needs some consistency adaptations between code and docstrings.
Other than that fine.

swh/storage/db.py
664–665

Retrieve the origin tuple (id, type, url) from ...

673

ori instead of url

675–676

same: Retrieve the origin tuple (id, type, url)...

686

ori instead of id.

This revision now requires changes to proceed.Jul 15 2019, 3:00 PM
vlorentz added inline comments.Jul 15 2019, 3:14 PM
swh/storage/db.py
673

why?

vlorentz updated this revision to Diff 5861.Jul 17 2019, 3:08 PM

fix internal representation (used by tests of the replayer)

swh-public-ci added a comment.Jul 17 2019, 3:13 PM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/561/ for more details.

Harbormaster completed remote builds in B6897: Diff 5861.Jul 17 2019, 3:13 PM
vlorentz updated this revision to Diff 5877.Jul 18 2019, 11:38 AM

update docstring

swh-public-ci added a comment.Jul 18 2019, 11:42 AM

Build is green
See https://jenkins.softwareheritage.org/job/DSTO/job/tox/562/ for more details.

Harbormaster completed remote builds in B6912: Diff 5877.Jul 18 2019, 11:42 AM
ardumont accepted this revision.Jul 18 2019, 12:05 PM

thanks

swh/storage/db.py
673

nvm, i misread

686

same, misreading ;)

This revision is now accepted and ready to land.Jul 18 2019, 12:05 PM
Closed by commit rDSTO7053da801fb4: Make origin_get ignore the `type` argument (authored by vlorentz). · Explain WhyJul 18 2019, 12:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
storage/
16 lines
6 lines
15 lines
tests/
71 lines

Diff 5879

View Options

swh/storage/db.py

Loading...
View Options

swh/storage/in_memory.py

Loading...
View Options

swh/storage/storage.py

Loading...
View Options

swh/storage/tests/test_storage.py

Loading...
About · Developer information · Legal