Differential D1679

settings/production: do not configure memcache if cache_uri is unset
ClosedPublic
Actions

Authored by douardda on Jul 3 2019, 10:50 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS99450ce0b9fc: settings/production: do not configure memcache if cache_uri is unset

Summary

this is needed so we can spawn a production-like webapp (in docker)
without a memcache (makes documentation writing easier).

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jul 3 2019, 10:50 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 3 2019, 10:50 AM

ardumont added a subscriber: ardumont.Jul 3 2019, 10:52 AM

ardumont added inline comments.

swh/web/settings/production.py
26–32	Shouldn't this be less strict (using dict's get method instead)?

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/573/ for more details.

Harbormaster completed remote builds in B6642: Diff 5634.Jul 3 2019, 10:55 AM

do not presume 'throttling.cache_uri' config exists

sounds better ;)

This revision is now accepted and ready to land.Jul 3 2019, 11:02 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/574/ for more details.

Harbormaster completed remote builds in B6643: Diff 5635.Jul 3 2019, 11:05 AM

Closed by commit rDWAPPS99450ce0b9fc: settings/production: do not configure memcache if cache_uri is unset (authored by douardda). · Explain WhyJul 3 2019, 11:12 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

settings/

production.py

13 lines

Diff 5636

View Options

swh/web/settings/production.py

settings/production: do not configure memcache if cache_uri is unsetClosedPublicActions