Differential D1621

Use functions instead of classes for route decorators.
ClosedPublic
Actions

Authored by vlorentz on Jun 20 2019, 2:37 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSb88f8a3fc6ae: Use functions instead of classes for route decorators.

Summary

It's more pythonic/idiomatic and consistent with what DRF does.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 20 2019, 2:37 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 20 2019, 2:37 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/516/ for more details.

Harbormaster completed remote builds in B6381: Diff 5396.Jun 20 2019, 2:43 PM

anlambert accepted this revision.Jun 20 2019, 3:08 PM

This revision is now accepted and ready to land.Jun 20 2019, 3:08 PM

Closed by commit rDWAPPSb88f8a3fc6ae: Use functions instead of classes for route decorators. (authored by vlorentz). · Explain WhyJun 20 2019, 3:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

admin/

adminurls.py

27 lines

api/

apidoc.py

127 lines

apiurls.py

44 lines

browse/

browseurls.py

37 lines

Diff 5397

View Options

swh/web/admin/adminurls.py

View Options

swh/web/api/apidoc.py

View Options

swh/web/api/apiurls.py

View Options

swh/web/browse/browseurls.py

Use functions instead of classes for route decorators.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5397

swh/web/admin/adminurls.py

swh/web/api/apidoc.py

swh/web/api/apiurls.py

swh/web/browse/browseurls.py

Use functions instead of classes for route decorators.
ClosedPublic
Actions

Revision Contents
Changeset List