Page MenuHomeSoftware Heritage
Differential D1619

Remove the duplicate endpoints list with <noscript>.
ClosedPublic
Actions

Authored by vlorentz on Jun 19 2019, 5:01 PM.

Details

Reviewers
anlambert
Group Reviewers
Reviewers
Commits
rDWAPPS6f053262a68e: Remove the duplicate endpoints list with <noscript>.
Summary

I don't understand what it's for.

Diff Detail

Repository
rDWAPPS Web applications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 19 2019, 5:01 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 19 2019, 5:01 PM
swh-public-ci added a comment.Jun 19 2019, 5:14 PM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/511/ for more details.

Harbormaster completed remote builds in B6355: Diff 5372.Jun 19 2019, 5:14 PM
anlambert accepted this revision.Jun 19 2019, 5:20 PM
anlambert added a subscriber: anlambert.

I think its was originally there to handle browsers with no JavaScript or with JavaScript disabled.

A quick test by disabling JavaScript in Firefox shows that the other table is displayed correctly (while the dynamic DataTables features are of course disabled).
So this can indeed be removed.

This revision is now accepted and ready to land.Jun 19 2019, 5:20 PM
vlorentz updated this revision to Diff 5382.Jun 20 2019, 10:10 AM

rebase

This revision was landed with ongoing or failed builds.Jun 20 2019, 10:10 AM
Closed by commit rDWAPPS6f053262a68e: Remove the duplicate endpoints list with <noscript>. (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B6366: Diff 5382!Jun 20 2019, 10:12 AM
swh-public-ci added a comment.Jun 20 2019, 10:12 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/512/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/512/console

Revision Contents
Changeset List

PathSize
swh/
web/
templates/
api/
8 lines

Diff 5383

View Options

swh/web/templates/api/endpoints.html

Loading...
About · Developer information · Legal