Page MenuHomeSoftware Heritage
Differential D1602

Use origin urls instead of origin ids (swh-loader-pypi)
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 3:37 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLDPY1c59be44133e: Use origin urls instead of origin ids.

Diff Detail

Repository
rDLDPY PyPI loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 3:37 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 3:37 PM
vlorentz mentioned this in T1816: Make all clients of swh-storage use origin URL as identifier and use visit types instead of origin types.Jun 18 2019, 3:38 PM
swh-public-ci added a comment.Jun 18 2019, 3:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDPY/job/tox/17/ for more details.

Harbormaster completed remote builds in B6290: Diff 5309.Jun 18 2019, 3:41 PM
ardumont accepted this revision.Jun 19 2019, 9:31 AM
ardumont added a subscriber: ardumont.

That's even clearer than before!
Thanks.

Wondering if the last snapshot could not be directly part of the loader-core now (with override from the loader itself if the implementation must diverge for some reason).

This revision is now accepted and ready to land.Jun 19 2019, 9:31 AM
vlorentz added a comment.Jun 19 2019, 10:42 AM

That's even clearer than before!

That's because origin_visit_get_latest did not exist, so loaders hacked around using snapshot_get_latest

Closed by commit rDLDPY1c59be44133e: Use origin urls instead of origin ids. (authored by vlorentz). · Explain WhyJun 19 2019, 10:43 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
pypi/
11 lines

Diff 5329

View Options

swh/loader/pypi/loader.py

Loading...
About · Developer information · Legal