Differential D1596

Remove dependency on swh-core.
ClosedPublic
Actions

Authored by vlorentz on Jun 18 2019, 1:41 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDMODb3250d297425: Remove dependency on swh-core.

Summary

This is a fix to workaround pip's inability to correctly solve
extra requirements (swh-model depends on swh-core[], but if other
packages depend on swh-model and swh-core[http], the 'http' extra
does not always get installed).

Diff Detail

Repository

rDMOD Data model

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jun 18 2019, 1:41 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 18 2019, 1:41 PM

olasd accepted this revision.Jun 18 2019, 1:43 PM

This revision is now accepted and ready to land.Jun 18 2019, 1:43 PM

Harbormaster completed remote builds in B6276: Diff 5297.Jun 18 2019, 1:44 PM

Build is green
See https://jenkins.softwareheritage.org/job/DMOD/job/tox/84/ for more details.

Closed by commit rDMODb3250d297425: Remove dependency on swh-core. (authored by vlorentz). · Explain WhyJun 18 2019, 1:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

requirements-swh.txt

swh/

model/

cli.py

5 lines

Diff 5298

View Options

requirements-swh.txt

View Options

Remove dependency on swh-core.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5298

requirements-swh.txt

swh/model/cli.py

Remove dependency on swh-core.
ClosedPublic
Actions

Revision Contents
Changeset List