Page MenuHomeSoftware Heritage
Differential D1364

swh.loader.core.utils: Add coverage on utils module
ClosedPublic
Actions

Authored by ardumont on Apr 6 2019, 11:09 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDLDBASE7837b03976e5: test_utils: Use @patch directly to declare expected behavior
rDLDBASEfd9ae7cb00ad: test_utils: Add coverage on utils module
Summary

Test clean_dangling_folders which is used by most of the loaders.

Test Plan

tox

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ardumont created this revision.Apr 6 2019, 11:09 AM
swh-public-ci added a comment.Apr 6 2019, 11:09 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/105/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/105/console

Harbormaster failed remote builds in B5171: Diff 4366!Apr 6 2019, 11:10 AM
ardumont updated this revision to Diff 4367.Apr 6 2019, 11:13 AM

Fix pep8 violations

(build failure: I have some setup issues with flake8/codespell i need
to attend to)

swh-public-ci added a comment.Apr 6 2019, 11:15 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/107/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/107/console

Harbormaster failed remote builds in B5172: Diff 4367!Apr 6 2019, 11:15 AM
ardumont updated this revision to Diff 4368.Apr 6 2019, 11:18 AM

Earlier python3 version are not happy with LocalPath so use string instead

Harbormaster failed remote builds in B5173: Diff 4368!Apr 6 2019, 11:20 AM
swh-public-ci added a comment.Apr 6 2019, 11:20 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/108/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/108/console

ardumont updated this revision to Diff 4369.Apr 6 2019, 11:31 AM

Refactor to deal with LocalPath limitations

/me annoyed

swh-public-ci added a comment.Apr 6 2019, 11:31 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/109/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/109/console

Harbormaster failed remote builds in B5174: Diff 4369!Apr 6 2019, 11:31 AM
ardumont updated this revision to Diff 4370.Apr 6 2019, 11:33 AM

Fix dangling variable

(fixed the pre-commit hook)

swh-public-ci added a comment.Apr 6 2019, 11:35 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/110/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/110/console

Harbormaster failed remote builds in B5175: Diff 4370!Apr 6 2019, 11:35 AM
ardumont updated this revision to Diff 4371.Apr 6 2019, 11:42 AM

Make the tests check the folder independently from order

I had a divergence between local testing and the ci's.

(I cannot use tox on my nixos machine right now so i use only pytest)

swh-public-ci added a comment.Apr 6 2019, 11:44 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/111/ for more details.

Harbormaster completed remote builds in B5176: Diff 4371.Apr 6 2019, 11:44 AM
ardumont updated this revision to Diff 4372.Apr 6 2019, 11:44 AM

Drop unneeded sorted instructions and format

ardumont retitled this revision from test_utils: Add coverage on utils module to swh.loader.core.utils: Add coverage on utils module.Apr 6 2019, 11:45 AM
ardumont added a project: Core Loader.
swh-public-ci added a comment.Apr 6 2019, 11:46 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/112/ for more details.

Harbormaster completed remote builds in B5177: Diff 4372.Apr 6 2019, 11:46 AM
vlorentz added a subscriber: vlorentz.Apr 8 2019, 9:59 AM

nitpick:

@patch('foo')
def test_bar(foo):
    foo.return_value = 42
    pass # ...

can be replaced by:

@patch('foo', 42)
def test_bar():
    pass # ...
vlorentz accepted this revision.Apr 8 2019, 9:59 AM
This revision is now accepted and ready to land.Apr 8 2019, 9:59 AM
ardumont updated this revision to Diff 4376.Apr 8 2019, 11:28 AM
  • test_utils: Use @patch directly to declare expected behavior
Harbormaster completed remote builds in B5181: Diff 4376.Apr 8 2019, 11:30 AM
swh-public-ci added a comment.Apr 8 2019, 11:30 AM

Build is green
See https://jenkins.softwareheritage.org/job/DLDBASE/job/tox/113/ for more details.

Closed by commit rDLDBASEfd9ae7cb00ad: test_utils: Add coverage on utils module (authored by ardumont). · Explain WhyApr 8 2019, 11:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
loader/
core/
tests/
111 lines

Diff 4377

View Options

swh/loader/core/tests/test_utils.py

Loading...
About · Developer information · Legal