Paths

Table of Contentst

Differential D1323

Checkboxes not aligned with text.
ClosedPublic
Actions

Authored by 01shobitha on Mar 31 2019, 2:46 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Maniphest Tasks

T1615: In the feature 'search' the check-boxes and text are not aligned.

Commits

rDWAPPS6d0aafd72c9b: Checkboxes not aligned with text.

Required Signatures

L3 Software Heritage Contributor License Agreement, version 1.0

Summary

The checkboxes are not aligned with the text in the Search feature in swh-web project.
Fixes T1615 with the checkboxes aligned with text. Made changes in the webapp.css file.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

01shobitha created this revision.Mar 31 2019, 2:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 31 2019, 2:46 PM

Herald added a required legal document: L3 Software Heritage Contributor License Agreement, version 1.0. · View Herald Transcript

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/369/ for more details.

Harbormaster completed remote builds in B4964: Diff 4202.Mar 31 2019, 2:50 PM

@01shobitha , can you sign our Contributor License Agreement ?
Without that step, I can not see your changes neither land that diff.

In D1323#28443, @anlambert wrote:

@01shobitha , can you sign our Contributor License Agreement ?
Without that step, I can not see your changes neither land that diff.

Signed the Contributor License Agreement.

Can you address my inline comment, rebase to origin/master and I will accept and merge that diff.

swh/web/assets/src/bundles/webapp/webapp.css
370	I would rather use: line-height: 1rem; instead of hardcoding the line height.

This revision now requires changes to proceed.Apr 1 2019, 11:50 AM

Changed to rem unit for line-height instead of px.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2019, 2:29 PM

This revision was landed with ongoing or failed builds.

Closed by commit rDWAPPS6d0aafd72c9b: Checkboxes not aligned with text. (authored by 01shobitha, committed by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

Thanks, landed!

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/370/ for more details.

Harbormaster completed remote builds in B4978: Diff 4215.Apr 1 2019, 2:31 PM

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

webapp/

webapp.css

1 line

Diff 4216

View Options

swh/web/assets/src/bundles/webapp/webapp.css

Checkboxes not aligned with text.ClosedPublicActions