After the last improvements in cli --lister and --create-tables options are no more valid but are still present in README of lister. Hence updated the README.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T1590: lister: Update readme instructions to be able to run listers after a git clone
- Commits
- rDLS26232db92666: Removed Extra blank space
rDLSbe804be0fcb4: Removed unnecessary files
rDLSd7ae2f1305c2: Updated README for listers
rDLSfa9113236442: Removed extra space from the README
rDLS5acb1fefc11e: Updated README.md for listers - Required Signatures
L3 Software Heritage Contributor License Agreement, version 1.0
Diff Detail
Diff Detail
- Repository
- rDLS Listers
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/82/ for more details.
Comment Actions
Hello,
Nice to see this diff happening, cool.
Please, adapt according to my remarks and update the diff.
Also, don't forget to sign the document mentioned at the top of the diff ;)
Cheers,
| README.md | ||
|---|---|---|
| 92 | Please, remove the extra blank space (same goes for the next command line below) | |
| swh/lister/.vscode/launch.json | ||
| 71 ↗ | (On Diff #4017) | Please, remove that file from the git history, that should not have been committed. |
| swh/lister/.vscode/settings.json | ||
| 10 ↗ | (On Diff #4017) | Same goes for this file, it should be removed from the commit (and the diff). |
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/83/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLS/job/tox/84/ for more details.
Comment Actions
I'll accept it because that's the perimeter we set out to fix.
For your information, the sample toplevels for the different listers are also out of date (it was mentioned earlier today in irc as well).
For example, the github lister should look like:
import logging logging.basicConfig(level=logging.DEBUG) from swh.lister.github.tasks import range_github_lister range_github_lister(364, 365)
Comment Actions
@nahimilega I did not notice you made so much commits.
rDLSfa9113236442: Removed extra space from the README rDLSbe804be0fcb4: Removed unnecessary files rDLS26232db92666: Removed Extra blank space rDLS5acb1fefc11e: Updated README.md for listers rDLSd7ae2f1305c2: Updated README for listers
Next time, please rebase interactively and squash the commits together.
The change is small enough that i think it's not relevant to see so many actions in the git history.
Another nitpick is the use of the verb, be imperative, that reads better.
For example, here one commit with the following message would have been enough:
README: Update bootstrap db instructions
More information can be found at [1]
Comment Actions
@ardumont Ok, from next time I will remove unnecessary commits and rebase interactively. And I will go through the Git_style_guide once again. Thanks for your feedback. I will surely remember this for future references.
Comment Actions
@ardumont Ok, from next time I will remove unnecessary commits and rebase interactively. And I will go through the Git_style_guide once again. Thanks for your feedback. I will surely remember this for future references.
Cool.
Thanks again for your contribution already ;)
That's awesome.
Cheers,