Page MenuHomeSoftware Heritage
Differential D1270

api/server: fix the add_stream endpoint
ClosedPublic
Actions

Authored by douardda on Mar 19 2019, 11:44 AM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDOBJS039434c41018: api/server: fix the add_stream endpoint
rDOBJSf8de5851560e: api/server: replace asyncio coroutines by native ones
Summary

since received chunks must be decoded one at a time.

also replace asyncio coroutines by native ones

Diff Detail

Repository
rDOBJS Object storage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Mar 19 2019, 11:44 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 19 2019, 11:44 AM
swh-public-ci added a subscriber: swh-public-ci.Mar 19 2019, 11:46 AM

Build is green
See https://jenkins.softwareheritage.org/job/DOBJS/job/tox/22/ for more details.

Harbormaster completed remote builds in B4719: Diff 4003.Mar 19 2019, 11:46 AM
vlorentz added a subscriber: vlorentz.Mar 19 2019, 11:58 AM

also replace asyncio coroutines by native ones

Aren't these only available starting with python 3.7?

vlorentz accepted this revision.Mar 19 2019, 12:08 PM

nvm, 3.7 makes them keyword, but this syntax is valid in 3.5 too.

This revision is now accepted and ready to land.Mar 19 2019, 12:08 PM
Closed by commit rDOBJSf8de5851560e: api/server: replace asyncio coroutines by native ones (authored by douardda). · Explain WhyMar 20 2019, 12:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
swh/
objstorage/
api/
64 lines

Diff 4030

View Options

swh/objstorage/api/server.py

Loading...
About · Developer information · Legal