Update outdated tar loading documentation (changed in 379a7a4b65f1).
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDTAR49d5a66c7fe0: README: update loading instructions (now using celery task)
Diff Detail
Diff Detail
- Repository
- rDLDTAR Tarball Loader
- Branch
- update-readme
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4634 Build 6152: tox-on-jenkins Jenkins Build 6151: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/68/ for more details.
README.md | ||
---|---|---|
35 | That's no longer the right way to do it (while it technically still works ;) That must go within the same configuration as the loader's configuration (under the celery key): I'd rework the documentation's as: ## Configuration This is the loader's (or task's) configuration file. It holds information for the loader to work (including celery configuration). This file is detected by the celery worker by checking the SWH_CONFIG_FILENAME environment variable. Here is a sample: ```YAML working_dir: /home/storage/tmp/ storage: cls: remote args: url: http://localhost:5002/ celery: task_modules: - swh.loader.tar.tasks task_queues: - swh_loader_tar # <- deprecated queue name - swh.loader.tar.tasks.LoadTarRepository # <- use this Can you please adapt accordingly? Note: the sentence phrasing is not that good, so feel free to improve ;) Cheers, |
Comment Actions
Thanks for this!
That documents a deprecated behavior though, can you please readapt according to my remark?
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/105/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/106/ for more details.