Differential D1067

Allow to override celery config file name via the SWH_CONFIG_FILENAME env var
ClosedPublic
Actions

Authored by douardda on Feb 1 2019, 5:00 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSCHabfe3db7f227: Allow to override celery config file name via the SWH_CONFIG_FILENAME env var

Summary

this will take precedence over the implicit config file scheme. The expected
config file given via the environment variable is expected to have a
[celery] section which will be used as config for the Celery app created
in swh.scheduler.celery_backend.config.

Related to T1410 and T826.

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Feb 1 2019, 5:00 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2019, 5:00 PM

douardda mentioned this in D1066: Allow to override config file name via the SWH_CONFIG_FILENAME env var.Feb 1 2019, 5:00 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/156/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/156/console

Harbormaster failed remote builds in B3966: Diff 3371!Feb 1 2019, 5:02 PM

ardumont accepted this revision.Feb 1 2019, 6:42 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/scheduler/celery_backend/config.py
245	i guess we'll see what that changes ;)

This revision is now accepted and ready to land.Feb 1 2019, 6:42 PM

douardda marked an inline comment as done.Feb 4 2019, 11:23 AM

douardda added inline comments.

swh/scheduler/celery_backend/config.py
245	In fact, with the recent modifications in config file handling, this is a noop, the 'task_soft_time_limit' from CONFIG is already passed to the celery app.