Page MenuHomeSoftware Heritage

Add support for an alternate codemeta context URL.
ClosedPublic

Authored by vlorentz on Feb 1 2019, 1:58 PM.

Details

Summary

Seen in production.

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 1 2019, 1:58 PM
ardumont accepted this revision.Feb 1 2019, 2:03 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/codemeta.py
105

why not:

if url in CODEMETA_CONTEXT_URLS:

CODEMETA_CONTEXT_URLS being the list of accepted context urls?

Is the first one the more frequent value?

This revision is now accepted and ready to land.Feb 1 2019, 2:03 PM
vlorentz marked an inline comment as done.Feb 1 2019, 3:05 PM
vlorentz added inline comments.
swh/indexer/codemeta.py
105

The first one is the one recommended by CodeMeta. It's also the one we use in the indexers' output.

vlorentz updated this revision to Diff 3373.Feb 4 2019, 11:34 AM
  • rebase
This revision was automatically updated to reflect the committed changes.