Differential D1061

Add support for an alternate codemeta context URL.
ClosedPublic
Actions

Authored by vlorentz on Feb 1 2019, 1:58 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDCIDX480b6269c78d: Add support for an alternate codemeta context URL.

Summary

Seen in production.

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Feb 1 2019, 1:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 1 2019, 1:58 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/302/ for more details.

Harbormaster completed remote builds in B3933: Diff 3347.Feb 1 2019, 2:00 PM

ardumont accepted this revision.Feb 1 2019, 2:03 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/codemeta.py
105	why not: if url in CODEMETA_CONTEXT_URLS: CODEMETA_CONTEXT_URLS being the list of accepted context urls? Is the first one the more frequent value?

This revision is now accepted and ready to land.Feb 1 2019, 2:03 PM

vlorentz marked an inline comment as done.Feb 1 2019, 3:05 PM

vlorentz added inline comments.

swh/indexer/codemeta.py
105	The first one is the one recommended by CodeMeta. It's also the one we use in the indexers' output.

rebase

Closed by commit rDCIDX480b6269c78d: Add support for an alternate codemeta context URL. (authored by vlorentz). · Explain WhyFeb 4 2019, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3983: Diff 3373!Feb 4 2019, 11:34 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/309/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/309/console

Revision Contents
Changeset List

Path

Size

swh/

indexer/

6 lines

tests/

test_metadata.py

15 lines

Diff 3374

swh/indexer/codemeta.py

Loading...

swh/indexer/tests/test_metadata.py

Loading...