Differential D1021

Do not crash the listener if a message has already been ack'ed
ClosedPublic
Actions

Authored by douardda on Jan 29 2019, 2:53 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSCH12035447ba4c: Do not crash the listener if a message has already been ack'ed

Summary

Note sure whether we should be concerned by the fact this sometimes occurs
(under heavy load in the docker env).

Diff Detail

Repository

rDSCH Scheduling utilities

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

douardda created this revision.Jan 29 2019, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 29 2019, 2:53 PM

Harbormaster failed remote builds in B3802: Diff 3248!Jan 29 2019, 2:56 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/112/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/112/console

vlorentz accepted this revision.Jan 29 2019, 4:43 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/scheduler/celery_backend/listener.py
195	this function is getting too long

This revision is now accepted and ready to land.Jan 29 2019, 4:43 PM

rebased

Harbormaster failed remote builds in B3823: Diff 3269!Jan 30 2019, 10:38 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tox/127/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tox/127/console

Closed by commit rDSCH12035447ba4c: Do not crash the listener if a message has already been ack'ed (authored by douardda). · Explain WhyJan 30 2019, 10:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

scheduler/

celery_backend/

listener.py

33 lines

Diff 3274

View Options

swh/scheduler/celery_backend/listener.py

Do not crash the listener if a message has already been ack'edClosedPublicActions