Differential D1000

Add a Makefile with a check-staged target to please the pre-commit hook
ClosedPublic
Actions

Authored by olasd on Jan 24 2019, 5:16 PM.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Commits

rDENVcc26d77abd4a: Add a Makefile with a check-staged target to please the pre-commit hook
rCDFDcc26d77abd4a: Add a Makefile with a check-staged target to please the pre-commit hook

Summary

The pre-commit hook is automatically installed by mr and docker-compose
provides a check command, so we can use it.

Test Plan

make check-staged returns 0

Diff Detail

Repository

rCDFD Dockerfiles for developers

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jan 24 2019, 5:16 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 24 2019, 5:16 PM

Harbormaster completed remote builds in B3694: Diff 3168.Jan 24 2019, 5:16 PM

douardda accepted this revision.Jan 24 2019, 5:20 PM

This revision is now accepted and ready to land.Jan 24 2019, 5:20 PM

Fix PHONY target

Harbormaster completed remote builds in B3701: Diff 3175.Jan 24 2019, 5:45 PM

Closed by commit rCDFDcc26d77abd4a: Add a Makefile with a check-staged target to please the pre-commit hook (authored by olasd). · Explain WhyJan 24 2019, 5:48 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDENVcc26d77abd4a: Add a Makefile with a check-staged target to please the pre-commit hook.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

Path

Size

3 lines

Diff 3183

Makefile

Loading...