User Details
- User Since
- Apr 30 2021, 11:58 AM (196 w, 1 d)
Nov 4 2021
LGTM now. :)
Jul 20 2021
Looks good to me, thanks ! :)
I updated the code as you suggested (I had to raise exceptions in some cases otherwise my editor was complaining with No return statement).
Jul 19 2021
add explanation about opam root
use stats for tests, remove useless comments and print statements
fix opam loader task so the loader does use some storage
Jul 13 2021
use exception rather than print + exit, use more explicit messages
use tmpdir, use octal notation for permissions
fix task test, check that the opam root is valid
Jul 12 2021
I've added some tests and fixed one of the review (I don't think the other one is easily do-able for now...).
Jul 8 2021
Jul 7 2021
Jul 6 2021
Jul 5 2021
more explanations about opam in the docstring
Please don't merge now. I noticed while writing the loader that I'll need to add extra arguments to the loader. Will update the diff soon.
Jun 28 2021
add missing __init__.py in test to fix build
Jun 23 2021
I don't understand the build failure, does someone have any clue ?
@vlorentz thanks but it won't be necessary. I was on vacation, I'll update the diff this week with the tests. :)
Jun 9 2021
update the code according to the reviews
Jun 8 2021
update the code according to the reviews