Page MenuHomeSoftware Heritage
Feed Advanced Search

Jun 17 2021

aeviso updated the diff for D5880: Update methods associated to the origin-revision layer.

Rebase

Jun 17 2021, 2:48 PM
aeviso updated the diff for D5880: Update methods associated to the origin-revision layer.

Rebase

Jun 17 2021, 2:17 PM
aeviso updated the diff for D5863: Refactor RevisionEntry's parents iterator.

Rebase

Jun 17 2021, 2:16 PM
aeviso updated the diff for D5862: Rework ArchiveInterface.

Rebase

Jun 17 2021, 2:15 PM
aeviso updated the diff for D5863: Refactor RevisionEntry's parents iterator.

Rebase

Jun 17 2021, 2:15 PM
aeviso updated the diff for D5880: Update methods associated to the origin-revision layer.

Rebase

Jun 17 2021, 2:04 PM
aeviso requested review of D5884: Fix bugs when retrieving parents in RevisionEntry.
Jun 17 2021, 2:03 PM
aeviso updated the diff for D5863: Refactor RevisionEntry's parents iterator.

Rebase

Jun 17 2021, 2:03 PM
aeviso updated the diff for D5862: Rework ArchiveInterface.

Depends on D5884

Jun 17 2021, 2:02 PM

Jun 16 2021

aeviso requested review of D5880: Update methods associated to the origin-revision layer.
Jun 16 2021, 1:59 PM
aeviso updated the diff for D5863: Refactor RevisionEntry's parents iterator.

Rebase

Jun 16 2021, 10:40 AM
aeviso updated the diff for D5862: Rework ArchiveInterface.

Rebase

Jun 16 2021, 10:39 AM

Jun 15 2021

aeviso accepted D5872: Use the flavor in the db to choose the ProvenanceDB class to instanciate.
Jun 15 2021, 6:29 PM
aeviso accepted D5842: Refactor the provenanceDB.insert_relation().
Jun 15 2021, 6:29 PM
aeviso accepted D5829: Refactor the cache handling in ProvenanceDB.
Jun 15 2021, 6:28 PM
aeviso requested changes to D5841: Remove the without-path flavor of ProvenanceDB.
Jun 15 2021, 1:29 PM
aeviso committed R230:df1b1164a07f: Improve date parsing (authored by aeviso).
Improve date parsing
Jun 15 2021, 11:30 AM

Jun 14 2021

aeviso added inline comments to D5862: Rework ArchiveInterface.
Jun 14 2021, 3:02 PM
aeviso accepted D5861: Add a TimestampWithTimezone.to_datetime() method.
Jun 14 2021, 2:27 PM
aeviso requested changes to D5861: Add a TimestampWithTimezone.to_datetime() method.
Jun 14 2021, 2:14 PM
aeviso requested review of D5863: Refactor RevisionEntry's parents iterator.
Jun 14 2021, 2:12 PM
aeviso updated the diff for D5862: Rework ArchiveInterface.

Rebase

Jun 14 2021, 2:09 PM
aeviso requested review of D5862: Rework ArchiveInterface.
Jun 14 2021, 2:08 PM
aeviso closed D5849: Reorganize code.
Jun 14 2021, 12:15 PM
aeviso committed rDPROV206399eb8ae7: Reorganize code (authored by aeviso).
Reorganize code
Jun 14 2021, 12:15 PM
aeviso closed D5848: First stage of refactoring for the Provenance backend.
Jun 14 2021, 12:15 PM
aeviso committed rDPROVc4b1f31640b1: Split Provenance backend in two layers (authored by aeviso).
Split Provenance backend in two layers
Jun 14 2021, 12:15 PM
aeviso committed rDPROVf1a9fe8182a3: Refactor insertion methods in the Provenance backend (authored by aeviso).
Refactor insertion methods in the Provenance backend
Jun 14 2021, 12:15 PM
aeviso committed rDPROV3f99025d6d45: Simplify cache usage in the Provenance backend (authored by aeviso).
Simplify cache usage in the Provenance backend
Jun 14 2021, 12:15 PM
aeviso closed D5847: Improve out-of-order revision processing.
Jun 14 2021, 12:15 PM
aeviso committed rDPROVd1b476b27ac4: Improve out-of-order revision processing (authored by aeviso).
Improve out-of-order revision processing
Jun 14 2021, 12:15 PM
aeviso committed rDPROV30bff867e97f: Add isochrone graph tests for the remaining heuristics (authored by aeviso).
Add isochrone graph tests for the remaining heuristics
Jun 14 2021, 12:15 PM
aeviso committed rDPROVc2843ae5ba47: Add test for isochrone graph topology (authored by aeviso).
Add test for isochrone graph topology
Jun 14 2021, 12:15 PM
aeviso closed D5845: Add tests for isochrone graph topology.
Jun 14 2021, 12:15 PM
aeviso committed rDPROV1dd14205ba60: Add equality check functions to model classes (authored by aeviso).
Add equality check functions to model classes
Jun 14 2021, 12:15 PM
aeviso committed rDPROV9aaaedb3ebc9: Refactor OriginEntry to include info about visit date and snapshot (authored by aeviso).
Refactor OriginEntry to include info about visit date and snapshot
Jun 14 2021, 12:15 PM
aeviso closed D5822: Refactor origin-revision layer.
Jun 14 2021, 12:14 PM
aeviso committed rDPROVfa4942ddff35: Remove archive parameter from RevisionEntry (authored by aeviso).
Remove archive parameter from RevisionEntry
Jun 14 2021, 12:14 PM

Jun 11 2021

aeviso updated the diff for D5849: Reorganize code.

Rebase

Jun 11 2021, 6:16 PM
aeviso updated the diff for D5848: First stage of refactoring for the Provenance backend.

Rebase

Jun 11 2021, 6:16 PM
aeviso updated the diff for D5847: Improve out-of-order revision processing.

Rebase

Jun 11 2021, 6:15 PM
aeviso updated the diff for D5848: First stage of refactoring for the Provenance backend.

Rebase

Jun 11 2021, 3:38 PM
aeviso updated the diff for D5847: Improve out-of-order revision processing.

Rebase

Jun 11 2021, 3:37 PM
aeviso updated the diff for D5845: Add tests for isochrone graph topology.

Rebase

Jun 11 2021, 3:33 PM
aeviso updated the diff for D5822: Refactor origin-revision layer.

Rebase

Jun 11 2021, 3:23 PM
aeviso added inline comments to D5845: Add tests for isochrone graph topology.
Jun 11 2021, 2:42 PM
aeviso added inline comments to D5822: Refactor origin-revision layer.
Jun 11 2021, 1:14 PM
aeviso added inline comments to D5847: Improve out-of-order revision processing.
Jun 11 2021, 1:04 PM
aeviso added inline comments to D5845: Add tests for isochrone graph topology.
Jun 11 2021, 12:32 PM
aeviso added inline comments to D5845: Add tests for isochrone graph topology.
Jun 11 2021, 12:27 PM
aeviso added inline comments to D5845: Add tests for isochrone graph topology.
Jun 11 2021, 12:05 PM
aeviso added inline comments to D5847: Improve out-of-order revision processing.
Jun 11 2021, 11:17 AM
aeviso added inline comments to D5847: Improve out-of-order revision processing.
Jun 11 2021, 11:01 AM

Jun 10 2021

aeviso updated the diff for D5849: Reorganize code.

Rebase

Jun 10 2021, 10:07 PM
aeviso updated the diff for D5848: First stage of refactoring for the Provenance backend.

Rebase

Jun 10 2021, 10:06 PM
aeviso updated the diff for D5847: Improve out-of-order revision processing.

Rebase

Jun 10 2021, 10:05 PM
aeviso updated the diff for D5845: Add tests for isochrone graph topology.

Rebase

Jun 10 2021, 10:03 PM
aeviso updated the diff for D5822: Refactor origin-revision layer.

Rebase

Jun 10 2021, 10:00 PM
aeviso added inline comments to D5848: First stage of refactoring for the Provenance backend.
Jun 10 2021, 9:21 PM
aeviso added inline comments to D5848: First stage of refactoring for the Provenance backend.
Jun 10 2021, 9:19 PM
aeviso added inline comments to D5845: Add tests for isochrone graph topology.
Jun 10 2021, 9:06 PM
aeviso added inline comments to D5847: Improve out-of-order revision processing.
Jun 10 2021, 3:10 PM
aeviso accepted D5823: Remove the CMDBTS dataset.
Jun 10 2021, 2:24 PM
aeviso requested review of D5849: Reorganize code.
Jun 10 2021, 12:49 PM
aeviso requested review of D5848: First stage of refactoring for the Provenance backend.
Jun 10 2021, 12:47 PM
aeviso requested review of D5847: Improve out-of-order revision processing.
Jun 10 2021, 12:24 PM
aeviso retitled D5845: Add tests for isochrone graph topology from Add isochrone graph tests to Add tests for isochrone graph topology.
Jun 10 2021, 12:20 PM
aeviso updated the summary of D5845: Add tests for isochrone graph topology.
Jun 10 2021, 12:20 PM
aeviso updated the diff for D5845: Add tests for isochrone graph topology.

Rework commit messages

Jun 10 2021, 12:16 PM
aeviso updated the diff for D5822: Refactor origin-revision layer.

Rework commit messages

Jun 10 2021, 12:15 PM
aeviso retitled D5845: Add tests for isochrone graph topology from Isochrone graph testing to Add isochrone graph tests.
Jun 10 2021, 12:04 PM
aeviso retitled D5822: Refactor origin-revision layer from Origin-revision layer refactoring to Refactor origin-revision layer.
Jun 10 2021, 12:04 PM
aeviso updated the summary of D5845: Add tests for isochrone graph topology.
Jun 10 2021, 12:02 PM
aeviso retitled D5822: Refactor origin-revision layer from Removed archive parameter from RevisionEntry since is was no longer required. to Origin-revision layer refactoring.
Jun 10 2021, 12:01 PM
aeviso requested review of D5845: Add tests for isochrone graph topology.
Jun 10 2021, 12:01 PM
aeviso updated the diff for D5822: Refactor origin-revision layer.

Merge requested fixes with actual revision

Jun 10 2021, 11:49 AM
aeviso updated the diff for D5822: Refactor origin-revision layer.

Updated diff with proper git revisions.

Jun 10 2021, 11:43 AM

Jun 7 2021

aeviso updated the diff for D5822: Refactor origin-revision layer.
  • Added equality check functions to model classes.
  • Merge branch 'master' of ssh://forge.softwareheritage.org/diffusion/222/swh-provenance
  • Added test for isochrone graph topology.
Jun 7 2021, 5:13 PM
aeviso updated the diff for D5822: Refactor origin-revision layer.
  • Requested fixes to CSVOriginIterator.
Jun 7 2021, 11:17 AM
aeviso added inline comments to D5822: Refactor origin-revision layer.
Jun 7 2021, 10:55 AM

Jun 4 2021

aeviso accepted D5821: Remove CMDBTS based tests.
Jun 4 2021, 4:28 PM
aeviso requested review of D5822: Refactor origin-revision layer.
Jun 4 2021, 4:06 PM
aeviso accepted D5812: Add a test_provenance_heuristics_content_find_all() test.

I believe this can be pushed safely. The issue about invalidating frontiers and batch revision processing should be treated separately.

Jun 4 2021, 3:27 PM
aeviso accepted D5811: Add a simple out-of-order dataset.
Jun 4 2021, 3:12 PM
aeviso added inline comments to D5805: Add a new (git) dataset generation scaffolding for tests.
Jun 4 2021, 1:54 PM
aeviso accepted D5773: Refactor the isochrone graph computation.
Jun 4 2021, 1:51 PM
aeviso added inline comments to D5773: Refactor the isochrone graph computation.
Jun 4 2021, 1:18 PM
aeviso accepted D5805: Add a new (git) dataset generation scaffolding for tests.
Jun 4 2021, 1:12 PM
aeviso added inline comments to D5773: Refactor the isochrone graph computation.
Jun 4 2021, 12:05 PM
aeviso added a comment to P1061 (An Untitled Masterwork).

That's not really a problem. For files, that delta is telling you when the file was seen for the first time. For directories, it tells you when the frontiers date, that should be greater or equal to all the content's. What we discussed yesterday should fix this mismatch but I insist, this is not a bug, it's the actual expected result with the current logic.

Jun 4 2021, 10:55 AM

Jun 2 2021

aeviso accepted D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

This diff is already accepted by ardumont, who knows SQL better than I do. There is no much for me to review here

Jun 2 2021, 4:56 PM
aeviso committed rDPROV49e47c3ea761: Complete pending ArchivePostgreSQL methods by using the Storage API equivalents. (authored by aeviso).
Complete pending ArchivePostgreSQL methods by using the Storage API equivalents.
Jun 2 2021, 2:18 PM
aeviso committed rDPROVf90844f50091: Removed old unused code. (authored by aeviso).
Removed old unused code.
Jun 2 2021, 2:18 PM
aeviso committed rDPROV58c57bca0a63: Added missing type annotation. (authored by aeviso).
Added missing type annotation.
Jun 2 2021, 2:18 PM
aeviso accepted D5780: Add a test for content_find_all().
Jun 2 2021, 1:24 PM
aeviso added a comment to D5781: Simplify DB queries in ProvenanceWithPathDB.content_find_(first|all).

We are about to start refactoring the provenance backend. It would be nice to have this changes pushed, since re-basing them might by complicated after refactoring.

Jun 2 2021, 1:22 PM
aeviso added a comment to D5813: Make ProvenanceDB.commit() optionally raise the exception.

Why would we want to do this? The actual idea is to guarantee that the commit method never fails, so we can remove the while not provenance.commit() line in the revision_add function.

Jun 2 2021, 1:20 PM
aeviso added inline comments to D5773: Refactor the isochrone graph computation.
Jun 2 2021, 1:17 PM

May 28 2021

aeviso requested changes to D5780: Add a test for content_find_all().
May 28 2021, 3:06 PM
aeviso requested changes to D5772: Add a test for the build_isochrone_graph() function.

Not sure if I follow what the test is doing since it not clear to me what's the content of storage_and_CMDBTS, but as far as I understand this is only testing that the id and maxdate of the root node matches with what's "expected". What about the rest of the graph? The topology of the full structure should be considered (assuming we know that's storage_and_CMDBTS and how provenace was populated).

May 28 2021, 2:54 PM