Differential D1567

Move Permalinks tabSlideout down in xs screens
ClosedPublic
Actions

Authored by kalpitk on Jun 9 2019, 9:02 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPSe160408c617c: Move Permalinks tabSlideout down in xs screens

Summary

Related T1786
'Permalinks' tabSlideout overlaps with Actions button in xs screens. Moved it 50px down on xs screens.

Diff Detail

Repository

rDWAPPS Web applications

Branch

permalinks

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6260
Build 8660: tox-on-jenkins	Jenkins
Build 8659: arc lint + arc unit

Event Timeline

kalpitk created this revision.Jun 9 2019, 9:02 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 9 2019, 9:02 AM

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/480/ for more details.

Harbormaster completed remote builds in B6119: Diff 5161.Jun 9 2019, 9:06 AM

Diff accepted but let's land D1583 first (see inline comment).

swh/web/assets/src/bundles/browse/swh-ids-utils.js
92	Once D1583 is landed, you should use the newly introduced constants here.

This revision is now accepted and ready to land.Jun 17 2019, 11:02 AM

Use Bootstrap breakpoint constant

Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/496/ for more details.

Harbormaster completed remote builds in B6260: Diff 5282.Jun 17 2019, 5:34 PM

Closed by commit rDWAPPSe160408c617c: Move Permalinks tabSlideout down in xs screens (authored by kalpitk). · Explain WhyJun 17 2019, 5:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

swh/

web/

assets/

src/

bundles/

browse/

swh-ids-utils.js

12 lines

Diff 5282

View Options

swh/web/assets/src/bundles/browse/swh-ids-utils.js

Move Permalinks tabSlideout down in xs screensClosedPublicActions