Add searchDelay of 1s to DataTable
Details
Details
- Reviewers
anlambert - Group Reviewers
Reviewers - Commits
- rDWAPPS61accbbfa50a: rate limit search in origin-save table
Diff Detail
Diff Detail
- Repository
- rDWAPPS Web applications
- Branch
- arcpatch-D1317
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 4958 Build 6632: tox-on-jenkins Jenkins Build 6631: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/361/ for more details.
Comment Actions
@kalpitk , can you give me more details about this change ?
Also, please run this in your shell:
arc set-config history.immutable true
Without this, arcanist amend your commit messages which force me to edit them before being able to land your diffs.
Comment Actions
@anlambert history.immutable is already set to true.
With the current implementation, we have no search delay. i.e. - every keydown triggers a request. In case of a big query, it unnecessarily sends requests. (Piles up unnecessary queries for the server)
with this Diff, request is sent when user finishes typing. (when no key is pressed for 1000 ms)
Comment Actions
@anlambert history.immutable is already set to true.
My bad, arcanist seems to apply some commit message template when I call arc patch from my side
to integrate your changes. I am not a big fan of that behavior but anyway.
We have other DataTable uses in swh-web assets. Can you also set the searchDelay option
to the remaining ones ?
Also you will have to rebase on master before updating the diff as we like to keep a linear history.
Comment Actions
@anlambert Oh the admin ones. Will update.
Anyways, how do I test as admin when I run it locally?
Comment Actions
You need to create a superuser account through the following command:
$ python3 -m swh.web.manage createsuperuserThen reach the /admin endpoint to log in and unlock the admin interface
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/363/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/366/ for more details.
Comment Actions
Build is green
See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/367/ for more details.