github: Reorder parameters in test_ratelimit_reset_sleep
AbandonedPublicDraft
Actions

Authored by anlambert on Jan 2 2023, 2:22 PM.

Details

Reviewers

None

Group Reviewers

Summary

Last commit fixes pytest issue on my machine but not on Jenkins (surely Python 3.7 related),
trying to reorder test parameters then.

Diff Detail

Repository

rDLS Listers

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33372
Build 52314: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52313: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	347 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.github.tests.test_lister::test_anonymous_ratelimit file /var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/github/tests/test_lister.py, line 140 def test_anonymous_ratelimit(swh_scheduler, caplog, requests_ratelimited) -> None: E fixture 'requests_ratelimited' not found
	361 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.github.tests.test_lister::test_from_empty_state swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7fcf351ebfd0> caplog = <_pytest.logging.LogCaptureFixture object at 0x7fcf351eb9e8> requests_mocker = <requests_mock.mocker.Mocker object at 0x7fcf351ebbe0>
	363 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.github.tests.test_lister::test_incremental swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7fcf3442b908> caplog = <_pytest.logging.LogCaptureFixture object at 0x7fcf3442b198> requests_mocker = <requests_mock.mocker.Mocker object at 0x7fcf3442b9e8>
	351 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.github.tests.test_lister::test_ratelimit_once_recovery[1] file /var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/github/tests/test_lister.py, line 176 @pytest.mark.parametrize( "num_ratelimit", [1]
	356 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.lister.github.tests.test_lister::test_ratelimit_reset_sleep[5-6-123456] file /var/lib/jenkins/workspace/DLS/tests-on-diff/.tox/py3/lib/python3.7/site-packages/swh/lister/github/tests/test_lister.py, line 208 @pytest.mark.parametrize( # Do 5 successful requests, return 6 ratelimits (to exhaust the credentials) with a
		View Full Test Results (6 Failed · 440 Passed)

Event Timeline

anlambert created this revision.Jan 2 2023, 2:22 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 2 2023, 2:22 PM

Build has FAILED

Patch application report for D8989 (id=32385)

Rebasing onto e218fbfef6...

Current branch diff-target is up to date.

Changes applied before test

commit 53fe78ada3ef37cf7aab6cc4f15519c2a7f99036
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Jan 2 14:20:08 2023 +0100

    github: Reorder parameters in test_ratelimit_reset_sleep

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/876/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/876/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 2 2023, 2:27 PM

Harbormaster failed remote builds in B33372: Diff 32385!

anlambert abandoned this revision.Jan 2 2023, 6:07 PM