Page MenuHomeSoftware Heritage
Differential D8978

Return a content list instead of an object to handle hash collisions
ClosedPublic
Actions

Authored by jayeshv on Dec 23 2022, 12:46 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDGQLa00c3ee76234: Return a content list instead of an object to handle hash collisions
Summary

Return a list of contents for ContentsByHashes and ContentsBySWHID entrypoints
Add a new entrypoint ContentByHashes to return a unique content object

Diff Detail

Repository
rDGQL GraphQL API
Branch
contents-by-hash
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33341
Build 52263: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 52262: arc lint + arc unit

Event Timeline

jayeshv created this revision.Dec 23 2022, 12:46 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 23 2022, 12:46 PM
swh-public-ci added a comment.Dec 23 2022, 12:48 PM

Build is green

Patch application report for D8978 (id=32354)

Rebasing onto 5446d4f87f...

Current branch diff-target is up to date.
Changes applied before test
commit 9123dd3eacf2113ec8d12cc316de7880e4648302
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content connection instead of an object to handle hash collisions
    
    Return a connection for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/263/ for more details.

Harbormaster completed remote builds in B33340: Diff 32354.Dec 23 2022, 12:48 PM
jayeshv requested review of this revision.Dec 23 2022, 12:48 PM
jayeshv updated this revision to Diff 32355.Dec 23 2022, 12:55 PM

typo fix and add missing args

swh-public-ci added a comment.Dec 23 2022, 12:58 PM

Build is green

Patch application report for D8978 (id=32355)

Rebasing onto 5446d4f87f...

Current branch diff-target is up to date.
Changes applied before test
commit 9ba4c2ac44c6e187780e823da96e3668ecbe8adf
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content connection instead of an object to handle hash collisions
    
    Return a connection for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/264/ for more details.

Harbormaster completed remote builds in B33341: Diff 32355.Dec 23 2022, 12:58 PM
jayeshv updated this revision to Diff 32360.Dec 23 2022, 6:43 PM

use non paginated lists instead of paginated connection

swh-public-ci added a comment.Dec 23 2022, 6:46 PM

Build is green

Patch application report for D8978 (id=32360)

Rebasing onto 419b841366...

Current branch diff-target is up to date.
Changes applied before test
commit 9466270db095ad53c34a32f7a6bac9a035e393e0
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/268/ for more details.

Harbormaster completed remote builds in B33346: Diff 32360.Dec 23 2022, 6:46 PM
jayeshv updated this revision to Diff 32366.Dec 23 2022, 6:52 PM

remove unused code

jayeshv retitled this revision from Return a content connection instead of an object to handle hash collisions to Return a content list instead of an object to handle hash collisions.Dec 23 2022, 6:52 PM
jayeshv edited the summary of this revision. (Show Details)
swh-public-ci added a comment.Dec 23 2022, 6:54 PM

Build is green

Patch application report for D8978 (id=32366)

Rebasing onto 419b841366...

Current branch diff-target is up to date.
Changes applied before test
commit 75f5ecce63e2f9ef71e5c353ed1caea4badbed7d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/269/ for more details.

Harbormaster completed remote builds in B33352: Diff 32366.Dec 23 2022, 6:54 PM
jayeshv updated this revision to Diff 32371.Dec 26 2022, 2:28 PM

rebase

swh-public-ci added a comment.Dec 26 2022, 2:30 PM

Build is green

Patch application report for D8978 (id=32371)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 95456b928853ee3540b65b99a9be46ed374f322d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/273/ for more details.

Harbormaster completed remote builds in B33357: Diff 32371.Dec 26 2022, 2:30 PM
jayeshv updated this revision to Diff 32374.Dec 28 2022, 10:39 AM

remove unused code

swh-public-ci added a comment.Dec 28 2022, 10:42 AM

Build is green

Patch application report for D8978 (id=32374)

Rebasing onto f6b5a2d5e5...

Current branch diff-target is up to date.
Changes applied before test
commit 05bb81113097a523c094835e3d92e72c18565a38
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/276/ for more details.

Harbormaster completed remote builds in B33360: Diff 32374.Dec 28 2022, 10:42 AM
vlorentz accepted this revision.Jan 2 2023, 12:22 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
swh/graphql/resolvers/content.py
19
121

Could you add type annotations to this function and the ones below?

This revision is now accepted and ready to land.Jan 2 2023, 12:22 PM
jayeshv updated this revision to Diff 32381.Jan 2 2023, 12:49 PM

add type hints

swh-public-ci added a comment.Jan 2 2023, 12:52 PM

Build is green

Patch application report for D8978 (id=32381)

Rebasing onto 413b4c733c...

Current branch diff-target is up to date.
Changes applied before test
commit 11bf3a4d7c6258ccea351ba1d4193f549e91c2a3
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/280/ for more details.

Harbormaster completed remote builds in B33367: Diff 32381.Jan 2 2023, 12:52 PM
jayeshv updated this revision to Diff 32382.Jan 2 2023, 1:21 PM

missing type

swh-public-ci added a comment.Jan 2 2023, 1:23 PM

Build is green

Patch application report for D8978 (id=32382)

Rebasing onto 413b4c733c...

Current branch diff-target is up to date.
Changes applied before test
commit a00c3ee76234e55ff726d9edfaafa4844ffdf76a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Fri Dec 23 09:50:46 2022 +0100

    Return a content list instead of an object to handle hash collisions
    
    Return a non paginated list for ContentsByHashes and ContentsBySWHID entrypoints
    Add a new entrypoint ContentByHashes to return a unique content object

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/281/ for more details.

Harbormaster completed remote builds in B33368: Diff 32382.Jan 2 2023, 1:23 PM
Closed by commit rDGQLa00c3ee76234: Return a content list instead of an object to handle hash collisions (authored by jayeshv). · Explain WhyJan 2 2023, 1:24 PM
This revision was automatically updated to reflect the committed changes.
jayeshv added a commit: rDGQLa00c3ee76234: Return a content list instead of an object to handle hash collisions.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
graphql/
errors/
2 lines100%
Loading...
4 lines100%
Loading...
resolvers/
96 lines98%
Loading...
13 lines100%
Loading...
27 lines100%
Loading...
schema/
89 lines--
tests/
functional/
143 lines100%
Loading...
unit/
resolvers/
4 lines100%
Loading...

Diff 32355

View Options

swh/graphql/errors/__init__.py

Loading...
View Options

swh/graphql/errors/errors.py

Loading...
View Options

swh/graphql/resolvers/content.py

Loading...
View Options

swh/graphql/resolvers/resolver_factory.py

Loading...
View Options

swh/graphql/resolvers/resolvers.py

Loading...
View Options

swh/graphql/schema/schema.graphql

Loading...
View Options

swh/graphql/tests/functional/test_content.py

Loading...
View Options

swh/graphql/tests/unit/resolvers/test_resolvers.py

Loading...
About · Developer information · Legal