Differential D8762

Puppet: Switch artifacts from dict to list
ClosedPublic
Actions

Authored by franckbret on Oct 25 2022, 10:10 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDLS8355fee25f57: Puppet: Switch artifacts from dict to list

Summary

Related T4519

Diff Detail

Repository

rDLS Listers

Branch

puppet

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32542
Build 50972: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50971: arc lint + arc unit

Event Timeline

franckbret created this revision.Oct 25 2022, 10:10 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 25 2022, 10:10 AM

Build is green

Patch application report for D8762 (id=31588)

Rebasing onto 8a82bbf95f...

Current branch diff-target is up to date.

Changes applied before test

commit 3fa90b098ec31d13fc1f57ecae7f0bfab95ac7b4
Author: Franck Bret <franck.bret@octobus.net>
Date:   Tue Oct 25 10:09:10 2022 +0200

    Puppet: Switch artifacts from dict to list

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/820/ for more details.

Harbormaster completed remote builds in B32542: Diff 31588.Oct 25 2022, 10:16 AM

franckbret requested review of this revision.Oct 25 2022, 10:16 AM

franckbret edited the summary of this revision. (Show Details)Oct 25 2022, 10:42 AM

Looks good to me, I guess you need to update the loader too.

This revision is now accepted and ready to land.Oct 25 2022, 11:01 AM

In D8762#227816, @anlambert wrote:

Looks good to me, I guess you need to update the loader too.

Yep I'm on it

franckbret mentioned this in D8766: Puppet: Artifacts as lists.Oct 25 2022, 2:47 PM

Rebase

This revision was landed with ongoing or failed builds.Oct 25 2022, 2:50 PM

Closed by commit rDLS8355fee25f57: Puppet: Switch artifacts from dict to list (authored by franckbret). · Explain Why

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLS8355fee25f57: Puppet: Switch artifacts from dict to list.

Build is green

Patch application report for D8762 (id=31609)

Rebasing onto ca4ab7f277...

Current branch diff-target is up to date.

Changes applied before test

commit 8355fee25f5763d5e13ccf1f926c173662ef0e38
Author: Franck Bret <franck.bret@octobus.net>
Date:   Tue Oct 25 10:09:10 2022 +0200

    Puppet: Switch artifacts from dict to list

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/829/ for more details.

Harbormaster completed remote builds in B32563: Diff 31609.Oct 25 2022, 2:55 PM

franckbret mentioned this in rDLDBASEe6847f36162f: Puppet: Artifacts as lists.Oct 25 2022, 3:09 PM