Differential D8633

Add missing unit and functional tests
ClosedPublic
Actions

Authored by jayeshv on Oct 5 2022, 5:26 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQLbc6f6a7269d2: Add missing unit and functional tests

Summary

Add unit tests for the server and scalars module
Remove unused code

Diff Detail

Repository

rDGQL GraphQL API

Branch

missing-tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32131
Build 50310: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50309: arc lint + arc unit

Event Timeline

jayeshv created this revision.Oct 5 2022, 5:26 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 5 2022, 5:26 PM

Build is green

Patch application report for D8633 (id=31173)

Rebasing onto 0f2eaba90f...

Current branch diff-target is up to date.

Changes applied before test

commit bc6f6a7269d25a523a067568451580d7f058ffb8
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Wed Oct 5 17:24:30 2022 +0200

    Add missing unit and functional tests
    
    Add unit tests for the server and scalars module
    Remove unused code

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/214/ for more details.

Harbormaster completed remote builds in B32131: Diff 31173.Oct 5 2022, 5:29 PM

jayeshv requested review of this revision.Oct 5 2022, 5:29 PM

vlorentz accepted this revision.Oct 6 2022, 11:47 AM

This revision is now accepted and ready to land.Oct 6 2022, 11:47 AM

Closed by commit rDGQLbc6f6a7269d2: Add missing unit and functional tests (authored by jayeshv). · Explain WhyOct 6 2022, 11:49 AM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQLbc6f6a7269d2: Add missing unit and functional tests.